On Sat, Apr 13, 2013 at 12:54:22AM +0300, Andrey Lebedev wrote:
On 04/12/2013 02:59 PM, Brian Sutherland wrote:
This is looking very very good, in my app very few tests are still failing.
Great! Now, as all our webtest fixes are released upstream, I plan to make an alpha release of what we've done so far. If you have any outstanding issues with new testbrowser, please report.
Just committed the last two. Sorry for the drip feed, but it takes a while to make simple test cases from the failures I see in my app. +1 to an alpha release soon.
I poked around at one and found that the way non-ascii in forms is handled has changed under python 2, here's a test that shows the problem:
https://github.com/zopefoundation/zope.testbrowser/commit/e0e965086c7fded415...
Thanks, I've fixed the testbrowser according to your testcase.
perfect
I'm not sure what the intention of the python 3 port is wrt unicode. Have you had any thoughts on the matter?
The idea is to make testbrowser to return/accept native strings instead of bytes/unicode for both py2 and py3. Under py2, controls will return str objects (for backwards compatibility), and under py3 that would be unicode strings (for usage convenience).
I guessed correctly then :) -- Brian Sutherland