-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Roman Joost wrote:
On Thu, Jun 17, 2010 at 07:59:18AM -0400, Tres Seaver wrote:
Roman, I landed my version of the fix in 'zope.testrunner', but didn't touch it in 'zope.testing', since you were working on it. I was rushing a little because I wanted to release 'zope.testrunner', but wanted to check with you first. The patch is here:
http://svn.zope.org/zope.testrunner/trunk/src/zope/testrunner/find.py?rev=11...
I'm fine with letting you land it in zope.testing, or even tweak it on the zope.testruner side, if you see a better fix. Thank you. I actually had troubles running all tests in zope.testrunner. I need to check why to be sure, to avoid commiting something broken.
Marius fixed the buildout for that.
I usually prefer to let someone more experienced review my code, although it seems to be not worth it for this little fix.
So to clarify - can I commit the patch to zope.testrunner after I verified that the tests are working fine on my local sandbox?
You should be able to check in just fine -- do you mean zope.testing, or zope.testrunner? I checked in my changes to zope.testrunner already. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkwbi6MACgkQ+gerLs4ltQ5mQACg0BejhsCAi8jw696URNPJ/KKh /6cAn0eFmusq+6EIlvSeudv+TdvpcG33 =6IHS -----END PGP SIGNATURE-----