Hello, I took the liberty to start the work by a first simple move : splitting apart what is "strictly" about PAU's core and the rest. PAU and some plugins have been put in : http://svn.zope.org/repos/main/zope.pluggableauth/trunk/ The rest has been kept in: http://svn.zope.org/repos/main/zope.app.authentication/branches/zope.pluggab... The tests pass and nothing has been changed but the imports. I people could already give me their feelings about it, it would be very constructive. There is still a lot of code that might need work. My concern was about the factories and the events. They look unnecessary to me in the core. I'm not sure, however, that people want to split that part. I hope to get some feedback so I can go on with the work and not lose the current momentum. - Souheil 2010/1/26 Christian Theune <ct@gocept.com>:
On 01/22/2010 07:59 PM, Souheil CHELFOUH wrote:
Hello guys,
I'm coding some stuff, using zope.app.authentication and this package appears to do too many things, in my opinion. Would it be wise to cut off some of the functionalities ? The pure PAU components could go in a dedicated package, like zope.pluggableauthservice The whole handling of principals, groups and folder makes it a bit hard to read and introduces a lot of redundancy if we wish to roll our own things. What do you guys think ?
Yeah, I think it would be nice to give that code a refactoring. Whenever I work with it I feel the urge to do so.
There's also subtle API annoyances that I'd like to get rid of but don't remember exactly right now.
How about a specific proposal?
Christian
-- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )