-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 ranjith kannikara wrote:
During the porting of Zope2 to python2.5 , the failures in the module Acquisition is regarding the C-API changes. This failures can be removed by mapping the function Wrapper_compare to tp_richcompare which is now mapped in to the tp_compare in the extension file Acquisition/_Acquisition.c. Part of the new code I introduced was copied from datetimemodule.c from Python 2.5 . Right now its not showing any failures or errors with both python2.4 and python2.5.
The patch is http://svn.zope.org/Zope/branches/gsoc-python-2.5/?rev=87371&view=rev
Please review this patch. Is this changes and the function from datetimemodule.c. If not is there any suggestions?
The patch looks fine. Are you saying that the 'diff_to_bool' function was pulled in from another project? If so, we likely need to ensure that we get the licensing correct on it. Also, is setting 'tp_compare' to a null needed to make the tests pass? Or was that just a precaution? Thanks for moving the ball forward! Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIUvNp+gerLs4ltQ4RAo5KAKDWpWsU50k5SK/8i/5P4fwprwrm+wCdGDH8 Bjl84QCrtaLNk/DK3j1u5+U= =oYoU -----END PGP SIGNATURE-----