On Fri, Jun 18, 2010 at 11:07:15AM -0400, Tres Seaver wrote:
Roman Joost wrote:
Thank you. I actually had troubles running all tests in zope.testrunner. I need to check why to be sure, to avoid commiting something broken.
Marius fixed the buildout for that. It was actually my bad - I ran the buildout/test with the wrong python version.
I usually prefer to let someone more experienced review my code, although it seems to be not worth it for this little fix.
So to clarify - can I commit the patch to zope.testrunner after I verified that the tests are working fine on my local sandbox?
You should be able to check in just fine -- do you mean zope.testing, or zope.testrunner? I checked in my changes to zope.testrunner already. I committed today - and yes, meant zope.testing :)
Cheers -- Roman Joost www: http://www.romanofski.de email: roman@bromeco.com