hello, I found a couple of problems while I was playing around with the WebServices package; I think this patch fixes them. The package looks very nice, especially the documentation. Unfortunately, I don't understand SOAP well enough yet to make any intelligible comments... Sean Index: SOAPMessage.py =================================================================== RCS file: /cvs-repository/Packages/WebService/SOAPMessage.py,v retrieving revision 1.1 diff -u -r1.1 SOAPMessage.py --- SOAPMessage.py 26 Nov 2001 16:18:22 -0000 1.1 +++ SOAPMessage.py 2 Dec 2001 22:35:23 -0000 @@ -118,7 +118,7 @@ def getParameter(self, name): """Return the named message parameter of the SOAP response.""" - for item in self.params: + for item in self.parameters: if item.name == name: return item return None Index: Transports.py =================================================================== RCS file: /cvs-repository/Packages/WebService/Transports.py,v retrieving revision 1.4 diff -u -r1.4 Transports.py --- Transports.py 29 Nov 2001 22:18:02 -0000 1.4 +++ Transports.py 2 Dec 2001 22:35:23 -0000 @@ -51,12 +51,11 @@ raise ValueError( 'This Python installation does not have SSL support.' ) - conn = TimeoutHTTPS(host, None, self.timeout) + conn = TimeoutHTTPS(host, None, self.timeout, + key_file=self.key_file, + cert_file=self.cert_file) else: - conn = TimeoutHTTP(host, None, self.timeout, - key_file = self.key_file, - cert_file = self.cert_file - ) + conn = TimeoutHTTP(host, None, self.timeout) conn.putrequest(verb, path)
On Sun, Dec 02, 2001 at 04:50:14PM -0600, sean.bowman@acm.org wrote:
I found a couple of problems while I was playing around with the WebServices package; I think this patch fixes them. The package looks very nice, especially the documentation. Unfortunately, I don't understand SOAP well enough yet to make any intelligible comments...
Hi Sean, Could you file your patch in the Zoe Collector at: http://collector.zope.org/Zope This way Brian Lloyd, the developer of the WebServices package, can find it as well. Thanks! -- Martijn Pieters | Software Engineer mailto:mj@zope.com | Zope Corporation http://www.zope.com/ | Creators of Zope http://www.zope.org/ ---------------------------------------------
participants (2)
-
Martijn Pieters -
sean.bowman@acm.org