zope.publisher 3.12 broke 25 zope.app packages
Hi there, 25 zope.app packages are broken due to changes in zope.publisher 3.12. zope.publisher had some components factored out of it into zope.login. I fixed zope.app.exception: it could be fixed by adding the zope.login requirement and adding a zcml include statement. I suspect most, probably all, other failures are similarly shallow. The breaking of so many packages wasn't noticed by anyone, until tests of svn checkouts that previously worked now broke. I hope we can put mechanisms in place so that developers of ZTK packages can be better made aware of breaking other packages that depend on the ZTK. This way the developer making the changes could do one or more of the following: * provide better backward compatibility * fix up the breaking packages * provide a better warning to others who are maintaining these packages that something was broken. I faintly, faintly recall we had such early-warning mechanisms in the past. :) Regards, Martijn
Hi there, Good news, it was only 24 packages, I counted wrong. :) Regards, Martijn
On Mon, Jan 4, 2010 at 11:51 PM, Martijn Faassen <faassen@startifact.com> wrote:
Good news, it was only 24 packages, I counted wrong. :)
Couldn't you have solved that by updating one underlying package, like zope.app.testing? Most of zope.app generally depends on things like app.testing, app.zcmlfiles or things like app.publsher. Hanno
Hanno Schlichting wrote:
On Mon, Jan 4, 2010 at 11:51 PM, Martijn Faassen <faassen@startifact.com> wrote:
Good news, it was only 24 packages, I counted wrong. :)
Couldn't you have solved that by updating one underlying package, like zope.app.testing? Most of zope.app generally depends on things like app.testing, app.zcmlfiles or things like app.publsher.
You're probably right - I am not really thinking straight today. Regards, Martijn
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Martijn Faassen wrote:
Hi there,
25 zope.app packages are broken due to changes in zope.publisher 3.12. zope.publisher had some components factored out of it into zope.login.
I fixed zope.app.exception: it could be fixed by adding the zope.login requirement and adding a zcml include statement. I suspect most, probably all, other failures are similarly shallow.
The breaking of so many packages wasn't noticed by anyone, until tests of svn checkouts that previously worked now broke.
I hope we can put mechanisms in place so that developers of ZTK packages can be better made aware of breaking other packages that depend on the ZTK. This way the developer making the changes could do one or more of the following:
* provide better backward compatibility
* fix up the breaking packages
* provide a better warning to others who are maintaining these packages that something was broken.
I faintly, faintly recall we had such early-warning mechanisms in the past. :)
AFAIK, the zope-tests list is the watchman on the battlements: seeing something break in its daily summary mail is usually the first warning I have that a checkin broke something. I would be glad to see other configurations sending their test results to that list, so that everybody gets notified about breakage. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAktD2X8ACgkQ+gerLs4ltQ4GOgCgqY4rrDVeio/TWp+/mzYWf4tH 1V4An0PeTUvwXOE7H0ii9HFbeyQa2AO7 =tkPS -----END PGP SIGNATURE-----
Martijn Faassen <faassen@startifact.com> wrote:
25 zope.app packages are broken due to changes in zope.publisher 3.12. zope.publisher had some components factored out of it into zope.login.
I fixed zope.app.exception: it could be fixed by adding the zope.login requirement and adding a zcml include statement. I suspect most, probably all, other failures are similarly shallow.
I just ran zope.app.exception's test and all pass. Thanks!! Do I understand correctly here that I can now release zope.app.exception too? regards, jw
participants (4)
-
Hanno Schlichting -
Jan-Wijbrand Kolman -
Martijn Faassen -
Tres Seaver