Hiya, I'm looking at the two patches that were uploaded for http://www.zope.org/Collectors/Zope/1810 which is assigned to me... BUT: 1) Have we reached the end of the 2.7 line? Do I need to apply this to the 2.7 branch? Or can I just put this on the trunk and 2.8 branches and leave it at that? I really hate having to deal with both CVS and SVN for one fix... 2) Since 2.8.1 is planned for tomorrow, should I a) hurry up and get it in before that, or b) wait because I don't want to risk merging a not-widely-tested patch so close to the final release? or c) just create a bugfix branch and leave it for somebody else to sort out the merge, since I'll be out of town for the next 2 weeks starting tomorrow and can't help if there's anything wrong with the fix? :-) thanks, PW
CRAP. On second thought, I may not be able to do anything about this at all. I am temporarily stuck using a win2000 box with cygwin, an environment in which I'm hardly an expert, and: - I can't get a working python 2.3 installed, it refuses to build the socket module, which is apparently a known cygwin bug; - I can't run unit tests on the zope trunk with python 2.4.1, they bail out with the traceback below. So, unless somebody else champions it, the fix won't be in 2.8.1. Here's the traceback: Traceback (most recent call last): File "test.py", line 917, in ? process_args() File "test.py", line 907, in process_args bad = main(module_filter, test_filter, libdir) File "test.py", line 697, in main runner(files, test_filter, debug) File "test.py", line 591, in runner s = get_suite(file, runner.result) File "test.py", line 507, in get_suite mod = package_import(modname) File "test.py", line 481, in package_import mod = __import__(modname) File "/zope/ZopeTrunk/lib/python/AccessControl/tests/testAcquisition.py", line 25, in ? Zope2.startup() File "/zope/ZopeTrunk/lib/python/Zope2/__init__.py", line 47, in startup _startup() File "/zope/ZopeTrunk/lib/python/Zope2/App/startup.py", line 95, in startup OFS.Application.initialize(application) File "/zope/ZopeTrunk/lib/python/OFS/Application.py", line 304, in initialize initializer.initialize() File "/zope/ZopeTrunk/lib/python/OFS/Application.py", line 333, in initialize self.install_products() File "/zope/ZopeTrunk/lib/python/OFS/Application.py", line 601, in install_pro ducts return install_products(app) File "/zope/ZopeTrunk/lib/python/OFS/Application.py", line 632, in install_pro ducts folder_permissions, raise_exc=debug_mode) File "/zope/ZopeTrunk/lib/python/OFS/Application.py", line 769, in install_pro duct productObject=App.Product.initializeProduct( File "/zope/ZopeTrunk/lib/python/App/Product.py", line 497, in initializeProdu ct products=app.Control_Panel.Products File "/zope/ZopeTrunk/lib/python/ZODB/Connection.py", line 704, in setstate self._setstate(obj) File "/zope/ZopeTrunk/lib/python/ZODB/Connection.py", line 760, in _setstate self._reader.setGhostState(obj, p) File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 495, in setGhostStat e state = self.getState(pickle) File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 488, in getState return unpickler.load() File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 436, in _persistent_ load return self._conn.get(oid) File "/zope/ZopeTrunk/lib/python/ZODB/Connection.py", line 208, in get obj = self._reader.getGhost(p) File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 482, in getGhost return klass.__new__(klass, *args) TypeError: Acquirer.__new__(UserFolder) is not safe, use Persistence.Persistent. __new__() ******************************************************** I get a similar error when attempting to start Zope: Traceback (most recent call last): File "/zope/ZopeTrunk/lib/python/Zope2/Startup/run.py", line 56, in ? run() File "/zope/ZopeTrunk/lib/python/Zope2/Startup/run.py", line 21, in run starter.prepare() File "/zope/ZopeTrunk/lib/python/Zope2/Startup/__init__.py", line 98, in prepa re self.startZope() File "/zope/ZopeTrunk/lib/python/Zope2/Startup/__init__.py", line 257, in star tZope Zope2.startup() File "/zope/ZopeTrunk/lib/python/Zope2/__init__.py", line 47, in startup _startup() File "/zope/ZopeTrunk/lib/python/Zope2/App/startup.py", line 90, in startup Globals.VersionNameName) File "/zope/ZopeTrunk/lib/python/App/ZApplication.py", line 32, in __init__ if not root.has_key(name): File "/zope/ZopeTrunk/lib/python/ZODB/Connection.py", line 704, in setstate self._setstate(obj) File "/zope/ZopeTrunk/lib/python/ZODB/Connection.py", line 760, in _setstate self._reader.setGhostState(obj, p) File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 495, in setGhostStat e state = self.getState(pickle) File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 488, in getState return unpickler.load() File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 436, in _persistent_ load return self._conn.get(oid) File "/zope/ZopeTrunk/lib/python/ZODB/Connection.py", line 208, in get obj = self._reader.getGhost(p) File "/zope/ZopeTrunk/lib/python/ZODB/serialize.py", line 482, in getGhost return klass.__new__(klass, *args) TypeError: Acquirer.__new__(Application) is not safe, use Persistence.Persistent.__new__()
Hiya,
I'm looking at the two patches that were uploaded for http://www.zope.org/Collectors/Zope/1810 which is assigned to me... BUT:
1) Have we reached the end of the 2.7 line? Do I need to apply this to the 2.7 branch? Or can I just put this on the trunk and 2.8 branches and leave it at that? I really hate having to deal with both CVS and SVN for one fix...
2) Since 2.8.1 is planned for tomorrow, should I a) hurry up and get it in before that, or b) wait because I don't want to risk merging a not-widely-tested patch so close to the final release? or c) just create a bugfix branch and leave it for somebody else to sort out the merge, since I'll be out of town for the next 2 weeks starting tomorrow and can't help if there's anything wrong with the fix? :-)
thanks,
PW
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Paul Winkler]
I'm looking at the two patches that were uploaded for http://www.zope.org/Collectors/Zope/1810 which is assigned to me... BUT:
1) Have we reached the end of the 2.7 line?
I expect that's Andreas's call now. I still plug away adding patches to the ZODB 3.2 line (which is maintained solely for the benefit of the Zope 2.7 line). If there won't be another 2.7-line release, I'd be delighted to retire the ZODB 3.2 line too.
Do I need to apply this to the 2.7 branch? Or can I just put this on the trunk and 2.8 branches and leave it at that? I really hate having to deal with both CVS and SVN for one fix...
Do it one place, do "cvs diff" or "svn diff" to create a patch, then apply the patch to the other place? That often works fine the first time.
2) Since 2.8.1 is planned for tomorrow, should I a) hurry up and get it in before that, or b) wait because I don't want to risk merging a not-widely-tested patch so close to the final release?
Does this require ZODB changes? If so, ZODB 3.4.1 final tarballs+installers have already been cut & tested (just awaiting upload & announcements). If I have to cut another ZODB release for Zope 2.8.1 (which is fine, if that's what's needed), the Zope 2.8.1 release should be delayed by a day to make enough time to do that.
or c) just create a bugfix branch and leave it for somebody else to sort out the merge, since I'll be out of town for the next 2 weeks starting tomorrow and can't help if there's anything wrong with the fix? :-)
Sounds like starting on #c now wouldn't be a waste of time in any case, and would leave all other options open.
--On 10. August 2005 08:54:59 -0500 Paul Winkler <pw_lists@slinkp.com> wrote:
Hiya,
I'm looking at the two patches that were uploaded for http://www.zope.org/Collectors/Zope/1810 which is assigned to me... BUT:
1) Have we reached the end of the 2.7 line? Do I need to apply this to the 2.7 branch? Or can I just put this on the trunk and 2.8 branches and leave it at that? I really hate having to deal with both CVS and SVN for one fix...
Why should we have reached the end? 2.7 should be supported as long as needed (I think at least for one further year) until 2.8 will be widely adopted (whatever that means). This means for me I will make releases as soon as their is a significant number of fixes or in case of important security fixes.
2) Since 2.8.1 is planned for tomorrow, should I a) hurry up and get it in before that, or b) wait because I don't want to risk merging a not-widely-tested patch so close to the final release? or c) just create a bugfix branch and leave it for somebody else to sort out the merge, since I'll be out of town for the next 2 weeks starting tomorrow and can't help if there's anything wrong with the fix? :-)
No further untested fixes or whatever are acceptable for 2.8.1. Please commit your fixes after the release tomorrow. Andreas
participants (3)
-
Andreas Jung -
Paul Winkler -
Tim Peters