Re: [Checkins] SVN: zope.app.container/trunk/src/zope/app/container/browser/adding.py 1 include per line
On Mon, Jun 16, 2008 at 4:42 AM, Christophe Combelles <ccomb@free.fr> wrote:
Log message for revision 87419: 1 include per line
Why's that? -- Benji York Senior Software Engineer Zope Corporation
Benji York a écrit :
On Mon, Jun 16, 2008 at 4:42 AM, Christophe Combelles <ccomb@free.fr> wrote:
Log message for revision 87419: 1 include per line
Why's that?
Not extremely important, but it's better for diffs and it allows easy-sorting of import lines. (and it's pep8) Christophe
On Mon, Jun 16, 2008 at 8:23 AM, Christophe Combelles <ccomb@free.fr> wrote:
Benji York a écrit :
On Mon, Jun 16, 2008 at 4:42 AM, Christophe Combelles <ccomb@free.fr> wrote:
Log message for revision 87419: 1 include per line
Why's that?
Not extremely important, but it's better for diffs and it allows easy-sorting of import lines. (and it's pep8)
It's not important (i.e., has little value), and not the status quo, that's why I brought it up. It's also not prescribed in PEP-8. In fact PEP-328 (http://www.python.org/dev/peps/pep-0328/#rationale-for-parentheses) was introduced -- in part -- to make it easier to import multiple things from a module. I don't think the change should be reverted, but I also wouldn't want this style to be promulgated. -- Benji York Senior Software Engineer Zope Corporation
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Benji York wrote:
On Mon, Jun 16, 2008 at 8:23 AM, Christophe Combelles <ccomb@free.fr> wrote:
Benji York a écrit :
On Mon, Jun 16, 2008 at 4:42 AM, Christophe Combelles <ccomb@free.fr> wrote:
Log message for revision 87419: 1 include per line Why's that? Not extremely important, but it's better for diffs and it allows easy-sorting of import lines. (and it's pep8)
It's not important (i.e., has little value), and not the status quo, that's why I brought it up.
It's also not prescribed in PEP-8. In fact PEP-328 (http://www.python.org/dev/peps/pep-0328/#rationale-for-parentheses) was introduced -- in part -- to make it easier to import multiple things from a module.
I don't think the change should be reverted, but I also wouldn't want this style to be promulgated.
The main advantage of the style is that any change to the imports in a module creates a full-line diff, which is easeier to read. The cost is extra verbosity. I prefer the full-line diffs myself. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIWF4d+gerLs4ltQ4RAltMAKC/Xn6ZEvgX7koXKGHtcsii0XtiqACfWtHb LDWIuM+GK4sK9OqXfaQnyN8= =sZl/ -----END PGP SIGNATURE-----
Hi
Betreff: [Zope-dev] Re: [Checkins] SVN:zope.app.container/trunk/src/zope/app/container/browser/ad ding.py1 include per line
On Mon, Jun 16, 2008 at 4:42 AM, Christophe Combelles <ccomb@free.fr> wrote:
Log message for revision 87419: 1 include per line
Why's that?
Why not ;-) I like one import per line too, because I get a better overview. But that's just a personal taste. Regards Roger Ineichen
participants (4)
-
Benji York -
Christophe Combelles -
Roger Ineichen -
Tres Seaver