zc.testbrowser.real support for mozlab 0.1.9
Hi, I've checked in a branch with changes to the testbrowser.real code to make it work with mozlab 0.1.9 (and firefox 3). Could someone please review the code and inform me, if I can merge it with the trunk? The branch can be found at svn.zope.org/repos/main/zc.testbrowser/branches/sweh-mozlab0.1.9 Regards, Sebastian -- Sebastian Wehrmann · sw@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 12 · fax +49 345 1229889 1 Zope and Plone consulting and development
On Thu, Jul 3, 2008 at 8:15 AM, Sebastian Wehrmann <sw@gocept.com> wrote:
Hi,
I've checked in a branch with changes to the testbrowser.real code to make it work with mozlab 0.1.9 (and firefox 3).
Cool.
Could someone please review the code and inform me, if I can merge it with the trunk?
I'll review it in the next couple of days and get back with you. -- Benji York Senior Software Engineer Zope Corporation
I've checked in a branch with changes to the testbrowser.real code to make it work with mozlab 0.1.9 (and firefox 3).
Hi Sebastian, This is great. I spent all day yesterday trying to make this happen and didn't get anywhere. Sometimes I wake up with a better idea as to how to solve things, but I don't often wake up to find all the work's been done! I tried running the tests with Python 2.4. About half the time they pass fine, and the other half fail something like this: File "<doctest README.txt[40]>", line 1, in ? browser.open('navigate.html') File "/Users/graham/development/patched_zc.testbrowser/src/zc/ testbrowser/real.py", line 201, in open self.wait() File "/Users/graham/development/patched_zc.testbrowser/src/zc/ testbrowser/real.py", line 193, in wait assert self.execute('tb_page_loaded;') == 'false' AssertionError though for varying pages with browser.open(). I don't understand what could be causing it; why would that value be changed in between those two lines? I guess the time.sleep() on line 191 implies that there's something we might want to wait for. I increased it by 10x and only got 1 failure out of 10, so I guess that helps. Thanks, Graham
On 2008-07-04 01:19:47 +0200, Graham Stratton <gns24@mythic-beasts.com> said:
I've checked in a branch with changes to the testbrowser.real code to make it work with mozlab 0.1.9 (and firefox 3).
Hi Sebastian,
This is great. I spent all day yesterday trying to make this happen and didn't get anywhere. Sometimes I wake up with a better idea as to how to solve things, but I don't often wake up to find all the work's been done!
I tried running the tests with Python 2.4. About half the time they pass fine, and the other half fail something like this:
File "<doctest README.txt[40]>", line 1, in ? browser.open('navigate.html') File "/Users/graham/development/patched_zc.testbrowser/src/zc/ testbrowser/real.py", line 201, in open self.wait() File "/Users/graham/development/patched_zc.testbrowser/src/zc/ testbrowser/real.py", line 193, in wait assert self.execute('tb_page_loaded;') == 'false' AssertionError
though for varying pages with browser.open(). I don't understand what could be causing it; why would that value be changed in between those two lines? I guess the time.sleep() on line 191 implies that there's something we might want to wait for. I increased it by 10x and only got 1 failure out of 10, so I guess that helps.
I had this error, too and checked in a maybe-fix in r87964. Have you tried with this revision or the one before? If it's thisone I'll add another loop there. -- Christian Zagrodnick · cz@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 4 · fax +49 345 1229889 1 Zope and Plone consulting and development
On 4 Jul 2008, at 17:34, Christian Zagrodnick wrote:
On 2008-07-04 01:19:47 +0200, Graham Stratton <gns24@mythic- beasts.com> said:
I tried running the tests with Python 2.4. About half the time they pass fine, and the other half fail something like this: File "<doctest README.txt[40]>", line 1, in ? browser.open('navigate.html') File "/Users/graham/development/patched_zc.testbrowser/src/ zc/ testbrowser/real.py", line 201, in open self.wait() File "/Users/graham/development/patched_zc.testbrowser/src/ zc/ testbrowser/real.py", line 193, in wait assert self.execute('tb_page_loaded;') == 'false' AssertionError though for varying pages with browser.open(). I don't understand what could be causing it; why would that value be changed in between those two lines? I guess the time.sleep() on line 191 implies that there's something we might want to wait for. I increased it by 10x and only got 1 failure out of 10, so I guess that helps.
I had this error, too and checked in a maybe-fix in r87964. Have you tried with this revision or the one before? If it's thisone I'll add another loop there.
I've tried with this revision, and with the timeout extended, but still occasionally see the problem. I have a couple of independent fixes for other issues which I'll discuss once this branch is merged. Regards, Graham
While using the zc.testbrowser.real testbrowser we encountered a 'bug' in browser.contents. The doctype and html-tags are swallowed. I submitted a bug fix in #87999 on my branch. Regards, Sebastian -- Sebastian Wehrmann · sw@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 12 · fax +49 345 1229889 1 Zope and Plone consulting and development
participants (4)
-
Benji York -
Christian Zagrodnick -
Graham Stratton -
Sebastian Wehrmann