Bug in zope.app.generations fixed and logging increased. Release?
Hi, I've fixed a bug in zope.app.generations and added more logging. Can someone have a look on this with a second pair of eyes and give me a go for releasing that code as 3.4.2? Christian -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development
On Mon, Nov 24, 2008 at 05:09:40PM +0100, Christian Theune wrote:
I've fixed a bug in zope.app.generations and added more logging. Can someone have a look on this with a second pair of eyes and give me a go for releasing that code as 3.4.2?
I looked at it, and it looks fine. The only thing I could nitpick about is that it's a bit unclear what the bug is about and why that patch fixes it just from looking at the patch -- but if you look at more context, it becomes blindingly obvious. Was this bug reported in launchpad? If so, it would be good to mention the bug number in the changelog; if not, it would be good to report it and then mention the bug number in the changelog before the release. Summary: +1 for releasing 3.4.2. Marius Gedminas -- "Wipe Info uses hexadecimal values to wipe files. This provides more security than wiping with decimal values." -- Norton SystemWorks 2002 Manual
Christian Theune a écrit :
Hi,
I've fixed a bug in zope.app.generations and added more logging. Can someone have a look on this with a second pair of eyes and give me a go for releasing that code as 3.4.2?
Is there something we can do for https://bugs.launchpad.net/zope3/+bug/241416 ? Christophe
Christian
------------------------------------------------------------------------
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
On Wed, 2008-11-26 at 12:08 +0200, Christophe Combelles wrote:
Christian Theune a écrit :
Hi,
I've fixed a bug in zope.app.generations and added more logging. Can someone have a look on this with a second pair of eyes and give me a go for releasing that code as 3.4.2?
Is there something we can do for https://bugs.launchpad.net/zope3/+bug/241416
Taking savepoints during the loop might be an idea. Christian -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development
participants (3)
-
Christian Theune -
Christophe Combelles -
Marius Gedminas