Policy for Collector-Issues 545 and 1217?
Hi, there are two collector-issues related to problems when Zope-Objects get ids like 'content_type' or 'URL1'. I think this problem exists for all names used in the REQUEST-object or general acquisitionable attributes of ObjectManagers. http://zope.org/Collectors/Zope/545 http://zope.org/Collectors/Zope/1217 I don't think that these issues cannot easily be solved in Zope2 without breaking the whole acquisition-magic. What to do? The problem exists, but a fix is hard to find... if at all. Accepting? Rejecting? Cheers, Maik
Maik Jablonski wrote:
Hi,
there are two collector-issues related to problems when Zope-Objects get ids like 'content_type' or 'URL1'. I think this problem exists for all names used in the REQUEST-object or general acquisitionable attributes of ObjectManagers.
http://zope.org/Collectors/Zope/545 http://zope.org/Collectors/Zope/1217
I don't think that these issues cannot easily be solved in Zope2 without breaking the whole acquisition-magic.
Sure they can. The problem is DTML and people not correctly limiting their namespace stacks when they should. Its not pretty when fixed because the code gets extremely verbose, but thats price of DTML.
What to do? The problem exists, but a fix is hard to find... if at all. Accepting? Rejecting?
Accept, they are completely fixable. I've probably already fixed those bugs in my fork, I'll hunt around and see if I can find the relevant files and post followups to the bugs. -- Jamie Heilman http://audible.transient.net/~jamie/
Jamie Heilman wrote:
Maik Jablonski wrote:
Hi,
there are two collector-issues related to problems when Zope-Objects get ids like 'content_type' or 'URL1'. I think this problem exists for all names used in the REQUEST-object or general acquisitionable attributes of ObjectManagers.
http://zope.org/Collectors/Zope/545 http://zope.org/Collectors/Zope/1217
I don't think that these issues cannot easily be solved in Zope2 without breaking the whole acquisition-magic.
Sure they can. The problem is DTML and people not correctly limiting their namespace stacks when they should. Its not pretty when fixed because the code gets extremely verbose, but thats price of DTML.
What to do? The problem exists, but a fix is hard to find... if at all. Accepting? Rejecting?
Accept, they are completely fixable. I've probably already fixed those bugs in my fork, I'll hunt around and see if I can find the relevant files and post followups to the bugs.
Sounds cool... I'm not sure if it's easy as you describe, but I hope so...:) Cheers, Maik
Maik Jablonski wrote:
Sounds cool... I'm not sure if it's easy as you describe, but I hope so...:)
Basically you just grep for URL1 in all dtml files, anywhere you see &dtml-URL1; or <dtml-var URL1 html_quote> and change it to <dtml-var "REQUEST.URL1" html_quote> IIRC "REQUEST" is safe to use. The culprit in this case is likely in manage_tabs.dtml I've never been able to reproduce the "content_type" bug. -- Jamie Heilman http://audible.transient.net/~jamie/ "Most people wouldn't know music if it came up and bit them on the ass." -Frank Zappa
here's the patch I'd have attached to http://zope.org/Collectors/Zope/1217 if the collector could collect -- Jamie Heilman http://audible.transient.net/~jamie/ "Paranoia is a disease unto itself, and may I add, the person standing next to you may not be who they appear to be, so take precaution." -Sathington Willoughby
[Jamie Heilman]
here's the patch I'd have attached to http://zope.org/Collectors/Zope/1217 if the collector could collect
FYI, I attached the patch to the collector report (nothing magical -- "it just worked" for me).
participants (3)
-
Jamie Heilman -
Maik Jablonski -
Tim Peters