-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway. Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIEie++gerLs4ltQ4RAsuxAKCC74aUHZzJwblAWEAyvvhu4S55AwCgpuwZ xSuzLdUKg/zi2uPFeFdMOB0= =qZSC -----END PGP SIGNATURE-----
Tres Seaver wrote:
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway.
Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits.
I'm +1 on doing it on trunk, but -1 for 2.11. Zope 2.11 is already in late beta and only needs a Zope 3.4 final to be released. From a Plone perspective I would like to keep 2.11 as compatible with 2.10 as it is right now, so we have an easy upgrade path for supporting blobs and getting the latest Zope libraries without breaking anything else. This would allow us Plone folks to use Zope 2.11 for one of the next minor feature update releases, say Plone 3.2 for example. Ripping out the Interface module would make it impossible for us to use 2.11 in any 3.x release of Plone. Hanno
+1 for trunk -1 for 2.11 branch Stefan On 25. Apr 2008, at 20:49, Tres Seaver wrote:
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it.
-- Anything that happens, happens. --Douglas Adams
--On 25. April 2008 21:39:14 +0200 "Stefan H. Holek" <stefan@epy.co.at> wrote:
+1 for trunk -1 for 2.11 branch
Same vote from my side. The 2.11 branch is in beta state and for this reason no major changes for 2.11 please. Andreas
Previously Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway.
Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits.
Isn't the policy to deprecate in release N and remove in N+2? -1 on removing in 2.11 +1 on deprecating in 2.11 Wichert. -- Wichert Akkerman <wichert@wiggy.net> It is simple to make things. http://www.wiggy.net/ It is hard to make things simple.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Wichert Akkerman wrote:
Previously Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway.
Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits.
Isn't the policy to deprecate in release N and remove in N+2?
They've been deprecated for five years.
-1 on removing in 2.11 +1 on deprecating in 2.11
I'll accept the *consensus fidelium* that they should be removed only in the trunk. Note that *any( code using the old interfaces (Plone has several places, I know) is a potential booby trap for other developers: I lost an hour or so yesterday trying to figure why the "positioning" UI was displaying on my IOrderableCOntainer, but the objects appeared not to move: the 'getObjPositionInParent' kludge was using sniffing for the Z2 version of the interface, instead of adapting. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIEy7L+gerLs4ltQ4RAjIfAKCbvY3EJ9iIuV7cKZd1kMhFskRdKQCgkXOn x7ZKCilkJldE5ABAs/27Wwc= =wojG -----END PGP SIGNATURE-----
Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Wichert Akkerman wrote:
Previously Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway.
Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits. Isn't the policy to deprecate in release N and remove in N+2?
They've been deprecated for five years.
I agree that they've been deprecated for years, so that shouldn't need to hold anything up. That said, the consensus seems to be to only remove them from the trunk, as Zope 2.11 in a stabilization phase. Removing them from the trunk means at least progress. Regards, Martijn
Previously Martijn Faassen wrote:
Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Wichert Akkerman wrote:
Previously Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway.
Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits. Isn't the policy to deprecate in release N and remove in N+2?
They've been deprecated for five years.
I agree that they've been deprecated for years, so that shouldn't need to hold anything up. That said, the consensus seems to be to only remove them from the trunk, as Zope 2.11 in a stabilization phase. Removing them from the trunk means at least progress.
Can we make them produce deprecation warnings in a release first? Even though they may technically be deprecated there I can not find a single mention of that fact in the Interface package itself or anywhere else. Only Interface.iclass is marked as deprecated. Wichert. -- Wichert Akkerman <wichert@wiggy.net> It is simple to make things. http://www.wiggy.net/ It is hard to make things simple.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Martijn Faassen wrote:
Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Wichert Akkerman wrote:
Previously Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it. THere is no *good* BBB reason to keep them around: anybody still depending on them in A.G. 2008 needs to switch over, anyway.
Objections? I'll fix the CMF breakage myself, but the Plone folks are going to have to revisit lots of grotty bits. Isn't the policy to deprecate in release N and remove in N+2? They've been deprecated for five years.
I agree that they've been deprecated for years, so that shouldn't need to hold anything up. That said, the consensus seems to be to only remove them from the trunk, as Zope 2.11 in a stabilization phase. Removing them from the trunk means at least progress.
I have checked in the changes on a new branch, made from the 2.11 branch as of today: http://svn.zope.org/Zope/branches/tseaver-2.11-no-z2-interfaces The intent is to merge the code only to the trunk (*not* to the 2.11 branch) from here. However, outside projects (CMF, Plone, Silva, etc.) could begin testing against that branch to find the breakage they need to repair. While excising the cruft, I noted a bunch of other cleanups which would make the code more habitable: - Consolidate interface definitions into the 'interfaces' module (or package) from current separate modules in ZCTextIndex, Sessions, and Transience products. - Clean up a bunch of crufty unit tests, again mostly in the products. I have the merge to the trunk done in my sandbox, and will likely check it in tomorrow unless somebody finds a timebomb. The merge went cleanly via: $ svn co $ZSVN/Zope/trunk Zope-trunk $ cd Zope-trunk $ svn merge -r 85793:85794 \ $ZSVN/Zope/branches/tseaver-2.11-no-z2-interfaces ... $ make clobber inplace ... $ /path/to/python test.py --all ... Total: 6592 tests, 0 failures, 0 errors in 26.892 seconds. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIFTMU+gerLs4ltQ4RAsC4AKC/LxLjAolvvoWAzq8Fm0P0zRqE0gCeKmTv oxKaezNcBTYEqBGfgPMqWes= =eXDz -----END PGP SIGNATURE-----
Tres Seaver wrote at 2008-4-25 14:49 -0400:
... I'd like to rip out the old Interface module from the 2.11 branch and the trunk, along with all the useless decoys which import it.
Is it not a bit late to do this for 2.11? 2.11 is already in the beta phase.... -- Dieter
participants (7)
-
Andreas Jung -
Dieter Maurer -
Hanno Schlichting -
Martijn Faassen -
Stefan H. Holek -
Tres Seaver -
Wichert Akkerman