What about replacing the default propertyLabel of PropertyManager with the one from CMF: def propertyLabel(self, id): """Return a label for the given property id """ for p in self._properties: if p['id'] == id: return p.get('label', id) return id The current one: def propertyLabel(self, id): """Return a label for the given property id """ return id Is kinda silly and this little change would make things neater, and remove the use of having it a separate function in CMF, where it really doesn't belong. Thoughts?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thursday, May 22, 2003, at 11:20 PM, Lennart Regebro wrote:
What about replacing the default propertyLabel of PropertyManager with the one from CMF:
def propertyLabel(self, id): """Return a label for the given property id """ for p in self._properties: if p['id'] == id: return p.get('label', id) return id
+1 Richard -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (Darwin) iD8DBQE+zXpjrGisBEHG6TARAnADAJwLJYzh7fTCBrVOGKNyaOhCpy7UwgCeNv9T +b89O1wdOvEd836M+AdG/YY= =RK4U -----END PGP SIGNATURE-----
Richard Jones wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thursday, May 22, 2003, at 11:20 PM, Lennart Regebro wrote:
What about replacing the default propertyLabel of PropertyManager with the one from CMF:
def propertyLabel(self, id): """Return a label for the given property id """ for p in self._properties: if p['id'] == id: return p.get('label', id) return id
+1
Overwhelming response indeed. At least nobody complained, so I'll do it. I think it's a new feature, so I'll only put it in HEAD.
On Tuesday 27 May 2003 1:14 pm, Lennart Regebro wrote:
Overwhelming response indeed. At least nobody complained, so I'll do it. I think it's a new feature, so I'll only put it in HEAD.
+1 all round. Doesnt that mean that every instance carries its own copy of the label? how does CMF use that? -- Toby Dickenson http://www.geminidataloggers.com/people/tdickenson
Toby Dickenson wrote:
On Tuesday 27 May 2003 1:14 pm, Lennart Regebro wrote:
Overwhelming response indeed. At least nobody complained, so I'll do it. I think it's a new feature, so I'll only put it in HEAD.
+1 all round.
Doesnt that mean that every instance carries its own copy of the label?
Hum. Yes, if you update the _properties attribute (by adding or removing properties) I guess it would.
how does CMF use that?
Not at all, it seems.
Lennart Regebro wrote:
Toby Dickenson wrote:
Doesnt that mean that every instance carries its own copy of the label?
Hum. Yes, if you update the _properties attribute (by adding or removing properties) I guess it would.
how does CMF use that?
Not at all, it seems.
CMF uses the property label for configuration of relatively simple tools such as CookieCrumbler. No thought was given to labeling instance-level properties, so there's currently no way to set up a label through the web. I'm not sure we need that anyway, since at that point it's probably better to use Formulator. Shane
participants (4)
-
Lennart Regebro -
Richard Jones -
Shane Hathaway -
Toby Dickenson