Hi all - Tres and I have been working to merge some final fixes, and I'd like to be able to make rc2 releases for 2.6.4 and 2.7.0 tomorrow. In the meantime, it would be helpful for anyone who runs from the 2.6 or 2.7 branches in CVS to update and let us know if you have any unresolved problems. It would be especially helpful for those who were having trouble with things like workflow scripts under the rc1 releases to give this a shot and let us know if the trouble is resolved. **Note that you need to rebuild the C extensions, due to a fix to cAccessControl. Be sure to do this before reporting any lingering issues!** Thanks, Brian Lloyd brian@zope.com V.P. Engineering 540.361.1716 Zope Corporation http://www.zope.com
Bingo, I tested with 2.7 and things work again. thanks for your efforts. Robert On Tuesday 27 January 2004 22:08, Brian Lloyd wrote:
Hi all -
Tres and I have been working to merge some final fixes, and I'd like to be able to make rc2 releases for 2.6.4 and 2.7.0 tomorrow.
In the meantime, it would be helpful for anyone who runs from the 2.6 or 2.7 branches in CVS to update and let us know if you have any unresolved problems.
It would be especially helpful for those who were having trouble with things like workflow scripts under the rc1 releases to give this a shot and let us know if the trouble is resolved.
**Note that you need to rebuild the C extensions, due to a fix to cAccessControl. Be sure to do this before reporting any lingering issues!**
Thanks,
Brian Lloyd brian@zope.com V.P. Engineering 540.361.1716 Zope Corporation http://www.zope.com
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Hi! Brian Lloyd wrote:
In the meantime, it would be helpful for anyone who runs from the 2.6 or 2.7 branches in CVS to update and let us know if you have any unresolved problems.
Right now I have no time to track this down myself, but the attached CMF test failures seem to be related to the last Zope changes. Don't know if these tests need to be updated or if they reveal a bug in Zope. Cheers, Yuppie ====================================================================== FAIL: test_createMemberArea (Products.CMFCore.tests.test_MembershipTool.MembershipToolSecurityTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/Zope-2.7/Products/CMFCore/tests/test_MembershipTool.py", line 82, in test_createMemberArea self.assertEqual( f.getOwner(), ownership ) File "/usr/lib/python2.3/unittest.py", line 302, in failUnlessEqual raise self.failureException, \ AssertionError: <DummyUser instance at 411215f0> != <DummyUser instance at 411215f0> ====================================================================== FAIL: test_constructContent (Products.CMFCore.tests.test_TypesTool.TypesToolTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/Zope-2.7/Products/CMFCore/tests/test_TypesTool.py", line 125, in test_constructContent self.assertEqual( f.getOwner(), acl_users.user_foo ) File "/usr/lib/python2.3/unittest.py", line 302, in failUnlessEqual raise self.failureException, \ AssertionError: <DummyUser instance at 41121770> != <DummyUser instance at 41121770> ====================================================================== FAIL: test_createMemberArea (Products.CMFDefault.tests.test_MembershipTool.MembershipToolSecurityTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/Zope-2.7/Products/CMFDefault/tests/test_MembershipTool.py", line 88, in test_createMemberArea self.assertEqual( f.getOwner(), ownership ) File "/usr/lib/python2.3/unittest.py", line 302, in failUnlessEqual raise self.failureException, \ AssertionError: <DummyUser instance at 411dd930> != <DummyUser instance at 411dd930> ---------------------------------------------------------------------- Ran 366 tests in 8.800s FAILED (failures=3)
On Wed, 28 Jan 2004 13:36:31 +0100 yuppie <y.2004_@wcm-solutions.de> wrote:
Hi!
Brian Lloyd wrote:
In the meantime, it would be helpful for anyone who runs from the 2.6 or 2.7 branches in CVS to update and let us know if you have any unresolved problems.
Right now I have no time to track this down myself, but the attached CMF test failures seem to be related to the last Zope changes. Don't know if these tests need to be updated or if they reveal a bug in Zope.
These tests seem pretty naive. I don't thing user objects promise to compare to one another in any way. Looks to me like the tests should be changed to something like: self.failUnless(f.getOwner() is ownership) -Casey
Hi! Casey Duncan wrote:
These tests seem pretty naive. I don't thing user objects promise to compare to one another in any way. Looks to me like the tests should be changed to something like:
self.failUnless(f.getOwner() is ownership)
That's not the problem. I had a closer look at this: Before the Owned API was changed getOwner() did return the wrapped user, now it returns the unwrapped user. If I replace getOwner() by the new getWrappedOwner() all tests pass. I'm not sure what this line in getOwner() means: <code> return aq_base(self.getWrappedOwner()) # ugh, backward compat. </code> Looks like backward compatibility code that breaks backward compatibility. Cheers, Yuppie
Before the Owned API was changed getOwner() did return the wrapped user, now it returns the unwrapped user. If I replace getOwner() by the new getWrappedOwner() all tests pass.
I'm not sure what this line in getOwner() means:
<code> return aq_base(self.getWrappedOwner()) # ugh, backward compat. </code>
Looks like backward compatibility code that breaks backward compatibility.
I think that's right. I checked in changes to all 3 branches that reverts the getOwner call to its original implementation (plus a deprecation warning for a case we want to get away from). I'm still tracking down what I hope is one final issue for rc2, but you should be able to update now and your original tests should pass. Brian Lloyd brian@zope.com V.P. Engineering 540.361.1716 Zope Corporation http://www.zope.com
participants (4)
-
Brian Lloyd -
Casey Duncan -
robert -
yuppie