Hi! On Windows, this 15 months old change in ZConfig sets the default hostname for inet_address to 'localhost': http://svn.zope.org/ZConfig/?rev=376&view=rev I have no idea why this was changed, the checkin message is not very helpful: "fix the default hostname for address datatypes for Windows" This ZConfig change is responsible for the Zope 2.8 release blocker http://www.zope.org/Collectors/Zope/1728 (the relevant info is in http://www.zope.org/Collectors/Zope/1507) and caused similar problems with Zope 3 http://www.zope.org/Collectors/Zope3-dev/383 http://mail.zope.org/pipermail/zope3-dev/2005-March/013770.html So if nobody can tell me why ZConfig was changed, I propose to 1.) revert the change and tag a new version of ZConfig 2.) update ZEO: the ZEO tests expect the old behavior, see http://mail.zope.org/pipermail/zope3-dev/2005-March/013794.html 3.) update Zope 2 trunk and Zope 3 trunk to the new versions of ZConfig and ZEO 4.) fix http://www.zope.org/Collectors/Zope/1507 and http://www.zope.org/Collectors/Zope3-dev/383 I'd volunteer to do the necessary changes in Zope 2. Any comments? Any volunteers for the other tasks? Cheers, Yuppie BTW: Why is ZConfig not a svn:external in Zope 2 and 3?
On Windows, this 15 months old change in ZConfig sets the default hostname for inet_address to 'localhost': ...
So if nobody can tell me why ZConfig was changed, I propose to
That sounds good to me, as I can't understand why Windows would be different here either. While looking at this, I stumbled across the following code in ZConfig/datatypes.py: ## AJ: We change 'localhost' to '' to force Medusa to use ## any network interface instead of using only 127.0.0.1. This is ## a not totally clean solution :-/ See also Collector #1507. if os.name == 'posix' and 'localhost' in hostname.lower(): hostname = '' 2 things struck me: * 'localhost' in hostname.lower() appears odd - I would expect ==. * that we probably want to do that for windows too As the comments explicitly reference 1507 and the code references 'localhost', it may be worth examining too. Cheers, Mark
Hi Mark! Mark Hammond wrote:
On Windows, this 15 months old change in ZConfig sets the default hostname for inet_address to 'localhost':
...
So if nobody can tell me why ZConfig was changed, I propose to
That sounds good to me, as I can't understand why Windows would be different here either.
I'm sure you know Windows much better than I, so it's good to know that you don't understand that either.
While looking at this, I stumbled across the following code in ZConfig/datatypes.py:
## AJ: We change 'localhost' to '' to force Medusa to use ## any network interface instead of using only 127.0.0.1. This is ## a not totally clean solution :-/ See also Collector #1507. if os.name == 'posix' and 'localhost' in hostname.lower(): hostname = ''
2 things struck me: * 'localhost' in hostname.lower() appears odd - I would expect ==. * that we probably want to do that for windows too
As the comments explicitly reference 1507 and the code references 'localhost', it may be worth examining too.
Well. I also stumbled over that code, but after looking at it for a while I realized get_default_host_info() is never called. So I'll remove those lines, not fix them ;) Cheers, Yuppie
participants (2)
-
Mark Hammond -
yuppie