encoding ignored for PageTemplate file uploads
Hi All, Unless I'm missing something, the encoding text field that forms part of the file upload form on page template instances is completely ignored since it's not used in the pt_upload method of ZopePageTemplate instances. Am I missing anything? Chris -- Simplistix - Content Management, Batch Processing & Python Consulting - http://www.simplistix.co.uk
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Chris Withers wrote:
Hi All,
Unless I'm missing something, the encoding text field that forms part of the file upload form on page template instances is completely ignored since it's not used in the pt_upload method of ZopePageTemplate instances.
Am I missing anything?
No - this parameter is ignored. The code in pt_edit assumes for text/html-ish content that the encoding is either iso-8859-15 as default or provided by the HTML content through the html-equiv mechanism. Either we treat the encoding field in the upload form as culprit and remove it or it could be used as dedicated encoding for text/html templates not providing an encoding specification themselves. - -aj -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQGUBAEBAgAGBQJMpzucAAoJEADcfz7u4AZjqt0LvApwPq+b5wxebB3ravit53KD yApMP22zMcoiWD4giKmcS4PHHOPmWh3KXDpAGdelfrdYmQRdC8ZB7Py/dWOTC5Tf zvbPYWigICjYXJ+G5Qz4mg2eqwLAAwoFYs451rwhSI50RlVagPyd4EIsR20Cxw8N mtKOeNFAgGWrCDbyf/4wLR4yLXamLc9PlYNktcYBj0WCOERcmf4kWTflFGpjxvki kL6U96sxR+1s6Iaxt4kof2F5qQGq6FGR6Uv9cUSXcC1/y9LlVLBRlHS+9m2lfr6I SejNzn4MKVcN5kCgbBbTi7jmOxDVACCukxjRVpEgSolBBolHOp3Bv6qOD54V0CIV cDX+bAkDwwalhL7YCFTjsG+7TzUGUEgAaRTomhgmgtzxTtQkCRsNjccjategmKTH 1dY72IDYAJJdqu+9oejNaaAO6iMdCez90PDF89ZZ/hRvfxYxVRomZDQnd1zjZURW DALGVdcuT/+s/no2YaSgmTWhBVpJPHU= =asM8 -----END PGP SIGNATURE-----
On Sat, Oct 02, 2010 at 04:03:08PM +0200, Andreas Jung wrote:
Chris Withers wrote:
Hi All,
Unless I'm missing something, the encoding text field that forms part of the file upload form on page template instances is completely ignored since it's not used in the pt_upload method of ZopePageTemplate instances.
Am I missing anything?
No - this parameter is ignored.
The code in pt_edit assumes for text/html-ish content that the encoding is either iso-8859-15 as default or provided by the HTML content through the html-equiv mechanism.
Either we treat the encoding field in the upload form as culprit and remove it or it could be used as dedicated encoding for text/html templates not providing an encoding specification themselves.
Not all page templates contain complete HTML pages; some are just snippets and won't have a <meta http-equiv...> I hope that's an argument for for making the encoding field work. Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development
participants (3)
-
Andreas Jung -
Chris Withers -
Marius Gedminas