Re: [Zope-dev] Re: [zope-xml] XMLDocument beta release
Chimezie Thomas-Ogbuji wrote Initially ClobXmlDocument started off as a seperate Product, however because of the various changes to internal Zope code, an incomplete grasp of the Product API, and the fact that XMLDocument is intended to be merged into Zope eventually, it was decided that it would be coded as internal products.
There doesn't seem to be any reason why it has to go there, tho - there's a number of existing "internal" Zope products that go in lib/python/Products. In particular OFS and Products/OFSP are already the dumping ground for all the unloved puppies in the Zope world :) so not putting stuff there is a Good Thing. Making it something that installs into existing directories makes it much harder to install, and makes it much more vulnerable to being broken when Zope is upgraded.
I haven't gone over the code changes, and it may be messy to determine them, but could you outline the changes you made? It would make it easier for integration into the next release
Okay. I ripped apart ClobXMLDocument and made it derive from DTMLDocument, rather than copy all of DTMLDocument's code. I also fixed the appropriate imports &c to make it work from a directory in Products. As an added advantage it now works with 2.2alpha as well (since the old code that was copied from DTMLDocument didn't work in 2.2) XSLTMethod I've done something similar to - the only piece left to do is the __call__ method - it copies the one from DTMLMethod for now. To make it work under 2.1.6, you'll want to keep your existing __call__ method, but lose the rest.
The final intent is for ClobXMLDocument to evolve to a fully heirarchical zope/dom tree (upon initial parse) and not just to contain the parsed XML as text -- much like the current XMLDocument. The feature set for the beta was for ClobXMLDocument to be a 'wrapper' -- a parsed object entity, if you will -- of XML content. Eventually, ClobXMLDocument (or XMLDocument as it will be called) itself will be a top level DOM node of the XML content.
Good. I was wondering :) since the current one seems pretty limited in what it can do from Zope. I'm glad that it's going to be moving to a fuller featured thing. Thanks, Anthony -- Anthony Baxter <anthony@interlink.com.au> It's never too late to have a happy childhood.
There doesn't seem to be any reason why it has to go there, tho - there's a number of existing "internal" Zope products that go in lib/python/Products. In particular OFS and Products/OFSP are already the dumping ground for all the unloved puppies in the Zope world :) so not putting stuff there is a Good Thing.
Making it something that installs into existing directories makes it much harder to install, and makes it much more vulnerable to being broken when Zope is upgraded.
Yes good, point. As a matter of fact the next release which I'll be putting up in a few secs has ClobXMLDocument (now called XMLDocument) and XSLTMethod as 'seperate' products to further simplify the installation process.
Okay. I ripped apart ClobXMLDocument and made it derive from DTMLDocument, rather than copy all of DTMLDocument's code. I also fixed the appropriate imports &c to make it work from a directory in Products. As an added advantage it now works with 2.2alpha as well (since the old code that was copied from DTMLDocument didn't work in 2.2)
Yes I reproduced alot of this in the upcoming release, however because of the HIGH potential that XMLDocment and XSLT Method (because of their hooks into 4Suite) eventually will evolve above and beyond DTML Method/Document implentation I didn't inherit off DTMLMethod and DTMLDocument, but left the cut and paste job for now.
XSLTMethod I've done something similar to - the only piece left to do is the __call__ method - it copies the one from DTMLMethod for now. To make it work under 2.1.6, you'll want to keep your existing __call__ method, but lose the rest.
Yeah I posted my issue with __call__ on the Wikki: http://216.164.72.7:7780/Wiki/Members/jim/ZDOM/Issue%20with%20__call__%20and...
Good. I was wondering :) since the current one seems pretty limited in what it can do from Zope. I'm glad that it's going to be moving to a fuller featured thing.
oh yes, XMLDocument has a lot of evolving left.
participants (2)
-
Anthony Baxter -
Chimezie Thomas-Ogbuji