Re: [Zope-dev] SVN: Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py Fix _getContextName; does anyone test this stuff?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Martijn Pieters wrote:
Log message for revision 109473: Fix _getContextName; does anyone test this stuff?
Changed: U Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py
-=- Modified: Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py =================================================================== --- Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py 2010-02-26 15:23:23 UTC (rev 109472) +++ Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py 2010-02-26 16:46:18 UTC (rev 109473) @@ -62,7 +62,7 @@ def _getContextName(self, context): if getattr(context, 'getId', None) is not None: return context.getId() - getattr(context, '__name__', None) + return getattr(context, '__name__', None)
def breadcrumbs(self): context = self.context
Kettle to pot: Did you add a test? Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkuIBUEACgkQ+gerLs4ltQ6wLQCgjoILR7DEUSnX8cP6RrMFyZuo ZyYAoLheP2E352KlZJA77fLcDRrfIiU5 =ATl+ -----END PGP SIGNATURE-----
2010/2/26 Tres Seaver <tseaver@palladion.com>:
Kettle to pot: Did you add a test?
I ran out of time; the current tests weren't easily molded to add a case for this. I felt that at least the simple 'return' statement fix should go in. I'll get the test case in this weekend, hopefully. -- Martijn Pieters
participants (2)
-
Martijn Pieters -
Tres Seaver