Re: [Zope-dev] Move implementation of getParent to zope.location?
On Wed, Aug 12, 2009 at 5:56 AM, Thomas Lotze<thomas@thomas-lotze.de> wrote:
Jim Fulton <jim@zope.com> schrieb:
I object to removing API functions that client code might use. (Was that a trick questions?) What is the point of this exercise?
Sorry, this message shouldn't have been sent in the state it was.
The original point of the exercise was to clean up the situation where the two closely related functions aren't part of the same APIs. Then I responded to the suggestion of removing the functions, noticing two things as I wrote: the functions are used by zope.app packages, and they are part of zope.traversing.api but not used by anything non-zope.app. As api-style modules have been questioned in the past, I wanted to raise the issue whether the functions are meant to remain part of that module or live in the ILocationInfo interface alone, but I got distracted at that point and for some reason sent the message, which I shouldn't have done.
If the functions remain in the api module, the remaining issue would be whether to move the implementation of getParent to zope.location and thus treat it like getParents.
Right. I understood this in the original proposal. Given that it doesn't break the existing API, I have no major problem with it, which is why I didn't bother to respond in the first place. I have a small problem that it fattens an existing API. I have a larger problem that we are wasting time on this. The cleanup doesn't seem worth it to me. I especially don't like that *I'm* spending time on this rather than, say, working on the kgs or our buildout discussions. Jim -- Jim Fulton
Hi there, On 08/12/2009 12:06 PM, Jim Fulton wrote:
Right. I understood this in the original proposal. Given that it doesn't break the existing API, I have no major problem with it, which is why I didn't bother to respond in the first place. I have a small problem that it fattens an existing API.
As far as I understand, the method is there and used and should have been in that existing API in the first place. Also, as you say it's only a small problem for you, I guess Thomas can go ahead moving it.
I have a larger problem that we are wasting time on this. The cleanup doesn't seem worth it to me. I especially don't like that *I'm* spending time on this rather than, say, working on the kgs or our buildout discussions.
I see truth in what you say, but this answer also takes energy from people who'd like to spend time on improving small things (which quickly sum up to larger things) pushing them away from contributing. I don't think we can afford that. Christian -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development
participants (2)
-
Christian Theune -
Jim Fulton