CRITICAL!!!! CVS: Zope/lib/python/OFS - Image.py:1.141.4.3
Hi, BIG PROBLEM WITH THIS CHECK-IN FROM YESTERDAY: I've updated my ZOPE and now all Images are broken!!! ZOPE lives behind a SQUID. I think that RESPONSE.setBase(None) is NOT a good idea at all!!! Commenting this out and all works as expected... Maybe someone else can check this issue... -mj Update of /cvs-repository/Zope/lib/python/OFS In directory cvs.zope.org:/tmp/cvs-serv2993/lib/python/OFS Modified Files: Tag: Zope-2_6-branch Image.py Log Message: Check in for #342 on behalf of slinkp === Zope/lib/python/OFS/Image.py 1.141.4.2 => 1.141.4.3 === --- Zope/lib/python/OFS/Image.py:1.141.4.2 Wed Nov 13 14:18:41 2002 +++ Zope/lib/python/OFS/Image.py Mon Dec 16 19:40:23 2002 @@ -133,6 +133,7 @@ Returns the contents of the file or image. Also, sets the Content-Type HTTP header to the objects content type. """ + # HTTP If-Modified-Since header handling. header=REQUEST.get_header('If-Modified-Since', None) if header is not None: @@ -374,7 +375,9 @@ self.ZCacheable_set(None) data=self.data - if type(data) is type(''): return data + if type(data) is type(''): + RESPONSE.setBase(None) + return data while data is not None: RESPONSE.write(data.data) _______________________________________________ Zope-Checkins maillist - Zope-Checkins@zope.org http://lists.zope.org/mailman/listinfo/zope-checkins
BIG PROBLEM WITH THIS CHECK-IN FROM YESTERDAY: I've updated my ZOPE and now all Images are broken!!! ZOPE lives behind a SQUID.
I think that
RESPONSE.setBase(None)
is NOT a good idea at all!!! Commenting this out and all works as expected...
Indeed -- the nightly unit tests also pointed this out. --Guido van Rossum (home page: http://www.python.org/~guido/)
I will go ahead and roll-back this change. Doing it now. -Casey On Tuesday 17 December 2002 08:03 am, Guido van Rossum wrote:
BIG PROBLEM WITH THIS CHECK-IN FROM YESTERDAY: I've updated my ZOPE and now all Images are broken!!! ZOPE lives behind a SQUID.
I think that
RESPONSE.setBase(None)
is NOT a good idea at all!!! Commenting this out and all works as expected...
Indeed -- the nightly unit tests also pointed this out.
--Guido van Rossum (home page: http://www.python.org/~guido/)
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
I think I know whats happened here, my earlier check in for that patch, changes SetBase in ZPublisher so it works. However that patch went in without a branch. http://lists.zope.org/pipermail/zope-checkins/2002-December/020453.html I did a cvs up -r Zope-2_6-branch -d before the check in, but probably didn't notice the following error, this is causing my cvs up to die and hence ZPublisher doesn't get the branch: cvs [server aborted]: could not find desired version 1.2 in /cvs-repository/Zope /lib/python/Signals/SignalHandler.py,v Anyone else getting that? Anyway if I could get this checked out correctly its just a matter of getting that patch in to the correct branch. Sorry Paul. -- Andy McKay ----- Original Message ----- From: "Casey Duncan" <casey@zope.com> To: "Guido van Rossum" <guido@python.org>; "Maik Jablonski" <maik.jablonski@uni-bielefeld.de> Cc: <zope-dev@zope.org> Sent: Tuesday, December 17, 2002 6:27 AM Subject: Re: [Zope-dev] CRITICAL!!!! CVS: Zope/lib/python/OFS - Image.py:1.141.4.3 I will go ahead and roll-back this change. Doing it now. -Casey On Tuesday 17 December 2002 08:03 am, Guido van Rossum wrote:
BIG PROBLEM WITH THIS CHECK-IN FROM YESTERDAY: I've updated my ZOPE and now all Images are broken!!! ZOPE lives behind a SQUID.
I think that
RESPONSE.setBase(None)
is NOT a good idea at all!!! Commenting this out and all works as expected...
Indeed -- the nightly unit tests also pointed this out.
--Guido van Rossum (home page: http://www.python.org/~guido/)
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Well there you go, I deleted my sandbox and did clean cvs checkout and it seems to have updated correctly. I've put back Paul's patches as he originally intended them to be. Sorry about that. -- Andy McKay
Andy McKay wrote:
Well there you go, I deleted my sandbox and did clean cvs checkout and it seems to have updated correctly. I've put back Paul's patches as he originally intended them to be.
Sorry about that.
Thank you, Andy! It works. I can see all my pretty images again... even if Zope runs behind a Squid...:) Cheers, Maik
On Tue, Dec 17, 2002 at 07:51:08PM +0100, Maik Jablonski wrote:
Andy McKay wrote:
Well there you go, I deleted my sandbox and did clean cvs checkout and it seems to have updated correctly. I've put back Paul's patches as he originally intended them to be.
Sorry about that.
Partly my fault, Andy - you asked me yesterday to verify that you'd checked in everything I'd sent you, and I said yes. There was also a change to lib/python/Products/OFSP/help/Response.py that was part of my fix for #342 as well, did that make it in? -- Paul Winkler http://www.slinkp.com "Welcome to Muppet Labs, where the future is made - today!"
participants (5)
-
Andy McKay -
Casey Duncan -
Guido van Rossum -
Maik Jablonski -
Paul Winkler