Code snippet:
def open(self, url, data=None): """See zope.testbrowser.interfaces.IBrowser""" url = str(url)
This string coercion is unfortunate, because ``mechanize`` accepts a (mechanize-) request-object in place of a URL string here. Using a custom request object allows us to do such things as setting the REQUEST_TYPE header string, which is not possible throught the standard API. Changeset comment: - Remove vendor import of mechanize. - Fix bug that caused HTTP exception tracebacks to differ between version 3.4.0 and 3.4.1. - Workaround for bug in Python Cookie.SimpleCookie when handling unicode strings. - Fix bug introduced in 3.4.1 that created incompatible tracebacks in doctests. This necessitated adding a patched mechanize to the source tree; patches have been sent to the mechanize project. Not sure which of the above this coercion is trying to solve, but perhaps it could be solved in a way that didn't break the mechanize functionality. \malthe
Malthe, On Mon, 2009-03-09 at 19:57 +0300, Malthe Borch wrote:
Code snippet:
def open(self, url, data=None): """See zope.testbrowser.interfaces.IBrowser""" url = str(url)
This string coercion is unfortunate, because ``mechanize`` accepts a (mechanize-) request-object in place of a URL string here. Using a custom request object allows us to do such things as setting the REQUEST_TYPE header string, which is not possible throught the standard API.
Changeset comment:
- Remove vendor import of mechanize.
- Fix bug that caused HTTP exception tracebacks to differ between version 3.4.0 and 3.4.1.
- Workaround for bug in Python Cookie.SimpleCookie when handling unicode strings.
- Fix bug introduced in 3.4.1 that created incompatible tracebacks in doctests. This necessitated adding a patched mechanize to the source tree; patches have been sent to the mechanize project.
Not sure which of the above this coercion is trying to solve, but perhaps it could be solved in a way that didn't break the mechanize functionality.
Did this get resolved by any means? As it didn't spur any discussion at all, you might want to at least file a bug tracker issue for that problem. Christian -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development
2009/3/18 Christian Theune <ct@gocept.com>:
Did this get resolved by any means? As it didn't spur any discussion at all, you might want to at least file a bug tracker issue for that problem.
It has now been filed as https://bugs.launchpad.net/zope3/+bug/344680. \malthe
participants (2)
-
Christian Theune -
Malthe Borch