Re: SVN: Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py Revert unwanted checkin.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Florent Guillaume wrote:
Log message for revision 68445: Revert unwanted checkin.
Changed: U Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py
-=- Modified: Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py =================================================================== --- Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py 2006-06-01 14:44:13 UTC (rev 68444) +++ Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py 2006-06-01 14:46:17 UTC (rev 68445) @@ -99,8 +99,6 @@ class ZopePathExpr(PathExpr):
def __init__(self, name, expr, engine): - if name == 'standard' and not expr: - expr = 'nothing' super(ZopePathExpr, self).__init__(name, expr, engine, boboAwareZopeTraverse)
Why revert? I was fine with this, rather than my warning-emitting version. Go ahead and forward-port it to the trunk, and close out the collector issue with a note saying "Zope2 allows empty path expressions" (maybe reference the issue in the code?) Tres. - -- =================================================================== Tres Seaver +1 202-558-7113 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFEfy7B+gerLs4ltQ4RApyTAKCmDBSKHNAuG3eTUH1Z/tLH59fKDQCgzT8X paaBvzwGUbuOhP5bB2kuRoA= =mIGe -----END PGP SIGNATURE-----
Tres Seaver wrote:
Florent Guillaume wrote:
Log message for revision 68445: Revert unwanted checkin.
Changed: U Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py
-=- Modified: Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py =================================================================== --- Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py 2006-06-01 14:44:13 UTC (rev 68444) +++ Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py 2006-06-01 14:46:17 UTC (rev 68445) @@ -99,8 +99,6 @@ class ZopePathExpr(PathExpr):
def __init__(self, name, expr, engine): - if name == 'standard' and not expr: - expr = 'nothing' super(ZopePathExpr, self).__init__(name, expr, engine, boboAwareZopeTraverse)
Why revert? I was fine with this, rather than my warning-emitting version. Go ahead and forward-port it to the trunk, and close out the collector issue with a note saying "Zope2 allows empty path expressions" (maybe reference the issue in the code?)
Cool, I guess this would answer the questions I had in my last entry of http://www.zope.org/Collectors/Zope/2118. Philipp
Philipp von Weitershausen wrote:
Tres Seaver wrote:
Florent Guillaume wrote:
Log message for revision 68445: Revert unwanted checkin.
Changed: U Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py
-=- Modified: Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py =================================================================== --- Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py 2006-06-01 14:44:13 UTC (rev 68444) +++ Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py 2006-06-01 14:46:17 UTC (rev 68445) @@ -99,8 +99,6 @@ class ZopePathExpr(PathExpr):
def __init__(self, name, expr, engine): - if name == 'standard' and not expr: - expr = 'nothing' super(ZopePathExpr, self).__init__(name, expr, engine, boboAwareZopeTraverse) Why revert? I was fine with this, rather than my warning-emitting version. Go ahead and forward-port it to the trunk, and close out the collector issue with a note saying "Zope2 allows empty path expressions" (maybe reference the issue in the code?)
Cool, I guess this would answer the questions I had in my last entry of http://www.zope.org/Collectors/Zope/2118.
Ok case closed ;) I checked this in: http://svn.zope.org/?view=rev&rev=68461 Florent -- Florent Guillaume, Nuxeo (Paris, France) Director of R&D +33 1 40 33 71 59 http://nuxeo.com fg@nuxeo.com
participants (3)
-
Florent Guillaume -
Philipp von Weitershausen -
Tres Seaver