HEADS UP: QA Problems with Zope 2
Hi, as I'm the guy who clicks the "build" button for the Zope 2 Windows releases I have the unfortunate honor to write his complaining mail: Situation ========= a) Zope 2.8 as of release a2 does not run bin/test.py anymore. Neither on Linux nor on Windows. Unfortunately this is the only testrunner worked on Windows at all. Now it is broken as well. (Import problems from Five.products or something) b) The WinBuilder environment isn't version managed along the Zope branches. The change of the Zope module to Zope2 required manual changes in the WinBuilder structure that broke and didn't got detected during continous tests. (See c) Additionally the requirements of specific versions Python, ZODB, winutils etc. are hardcoded in the Makefiles right now. c) There are no nightly tests for Windows at all. I know there is some suspended effort already around. Please notice this as a friendly reminder that I'd be very lucky having those catch errors *before* Andreas makes a release and I run the tests manually. d) zopectl on windows doesn't work (it barfs about SIG_CHILD not existing). I'm not sure if it ever did or if it should. If it should not work on windows anyway, maybe we should remove it in the windows distribution ... All in all, it's a very unsatisfying situation for the Windows users, and I'm pretty scared telling anybody about the situation when I'm asked. This really has to change at least a bit. What to do ========== Things I can do and propose to do to make this better: ------------------------------------------------------ b): I can either create branches for WinBuilders responding to the Zope Versions. Or (what I like better) I can put the WinBuilders somewhere in the Zope 2 tree to allow versioning along a branch automatically so continuous tests know where to get the WinBuilders from. c): If there is some infrastructure with the build bot around already and someone gives me pointers, I can set up nightly builds and tests on a Win2k machine over here. Additionally the tests should run on XP Server (or professional) and Win 2003 server as well. I don't have those around unfortunately + I don't have enough Visual Studio licenses around. Anyway, having at least one continuously running test is better than having none. Things I can't do anything right now on my own and need support: ---------------------------------------------------------------- a) I'm not able to look into the test runners (that are not broken solely on windows) nor to look into Five integration problems. I'd love if someone could a) either fix test.py or b) deprecate it and give me the hint to some other runner that works. test.py is included and should therefore work within a release or be removed. I'm not sure what is right here. d) I have no idea about zopectl on windows. Is there some knowledge around on this? ================ Final conclusion ================ I have a compiled Zope 2.8a2 around here, but I'm not able to run the unit tests on it and I'm not willing to publish it therefore because I have the suspicion that this branch never has seen windows before except the one pass of unit tests before 2.8a1. Cheers, Christian -- gocept gmbh & co. kg - schalaunische str. 6 - 06366 koethen - germany www.gocept.com - ct@gocept.com - phone +49 3496 30 99 112 - fax +49 3496 30 99 118 - zope and plone consulting and development
Christian Theune wrote:
a) I'm not able to look into the test runners (that are not broken solely on windows) nor to look into Five integration problems. I'd love if someone could a) either fix test.py or b) deprecate it and give me the hint to some other runner that works.
test.py is included and should therefore work within a release or be removed. I'm not sure what is right here.
I just added some missing files to setup.py. Could you please try again? There are still some broken z3 tests (setup works different for z3), but at least on linux test.py works now. Cheers, Yuppie
b): I can either create branches for WinBuilders responding to the Zope Versions. Or (what I like better) I can put the WinBuilders somewhere in the Zope 2 tree to allow versioning along a branch automatically so continuous tests know where to get the WinBuilders from.
+1 from me on merging WinBuilders into Zope. It took me quite some time to locate it first I looked, and having it external reinforces the 2nd-class status of Windows.
d) I have no idea about zopectl on windows. Is there some knowledge around on this?
I recall a message from Tim saying it has never worked and probably never will. IIUC correctly, its functionality isn't as desired on Windows due to the service support. Enfold has a simple log rotation strategy I have detailed in a previous mail to this list, and we will contribute code shortly. I have on my todo list for the next week (or 2) to steer through my service changes on both the 2.7 and 2.8 brances as discussed here recently. If that goes well, the Zope3 trunk will get a look-in too :) Printing-the-contrib-form-now ly, Mark
Hi, Am Montag, den 04.04.2005, 21:12 +1000 schrieb Mark Hammond:
d) I have no idea about zopectl on windows. Is there some knowledge around on this?
I recall a message from Tim saying it has never worked and probably never will. IIUC correctly, its functionality isn't as desired on Windows due to the service support. Enfold has a simple log rotation strategy I have detailed in a previous mail to this list, and we will contribute code shortly.
Yeah, I just wanted to try it for running 'zopectl test' but it fails earlier. Maybe it shouldn't be delivered then.
I have on my todo list for the next week (or 2) to steer through my service changes on both the 2.7 and 2.8 brances as discussed here recently. If that goes well, the Zope3 trunk will get a look-in too :)
Printing-the-contrib-form-now ly,
Great to see some reinforcements coming in! Christian -- gocept gmbh & co. kg - schalaunische str. 6 - 06366 koethen - germany www.gocept.com - ct@gocept.com - phone +49 3496 30 99 112 - fax +49 3496 30 99 118 - zope and plone consulting and development
... [Christian Theune]
d) I have no idea about zopectl on windows. Is there some knowledge around on this?
[Mark Hammond]
I recall a message from Tim saying it has never worked and probably never will.
Well, everything that builds on zdaemon is Unix-specific -- the underlying machinery uses stuff like this freely and ubiquitously: + Unix domain sockets. + os.fork() + The signals signal.SIGTERM, signal.SIGHUP, signal.SIGINT, and signal.SIGCHLD, with Unix semantics. If nothing else, it's a wonderful demonstration of how core Python allows writing wholly platform-specific code.
IIUC correctly, its functionality isn't as desired on Windows due to the service support.
Unix-heads certainly want it anyway; Windows-heads aren't used to anything better than the Windows services API, so they don't even bring it up.
Enfold has a simple log rotation strategy I have detailed in a previous mail to this list, and we will contribute code shortly.
Check it in too! Nobody is volunteering to look at your patches, and they're important. I can't make time for it myself (would if I could).
I have on my todo list for the next week (or 2) to steer through my service changes on both the 2.7 and 2.8 brances as discussed here recently. If that goes well, the Zope3 trunk will get a look-in too :)
The Zope3 Windows installers to date are produced via "setup.py bdist_wininst", and that's all. No Windows service support, no bundling of Python, no bundling of win32all, ..., the Zope3 Windows story really has nothing in common with Zope2's so far. That's a discussion for zope3-dev, though.
Printing-the-contrib-form-now ly,
Thank you. Poor Mark <0.5 wink>.
On Apr 4, 2005 4:53 PM, Tim Peters <tim.peters@gmail.com> wrote:
Unix-heads certainly want it anyway; Windows-heads aren't used to anything better than the Windows services API, so they don't even bring it up.
Well, it's not so much as API, but the fact that Windows people are used to starting a service through the control panel, and not through a python-script. After all, you don't need the python script. ;) Possibly zopectl could start the service if it's called on a windows machine, instead of trying to pretend that it runs on unix... I don't know how hard that would be. Also, I don't know how hard it would be to get rid of the unix specific things for running zopectl test and such... -- Lennart Regebro, Nuxeo http://www.nuxeo.com/ CPS Content Management http://www.cps-project.org/
[Christian Theune] ...
I have a compiled Zope 2.8a2 around here, but I'm not able to run the unit tests on it and I'm not willing to publish it therefore because I have the suspicion that this branch never has seen windows before except the one pass of unit tests before 2.8a1.
FYI, I usually run the Zope trunk tests once a day, on WinXP. None of this goes thru WinBuilders, though -- this is doing "test.py -vv --all" from the root of a trunk checkout immediately after "setup.py build_ext -i". The same two tests have been broken there since last October, but all other tests pass: http://www.zope.org/Collectors/Zope/1728 As recorded in the bug that points at, for related reasons an installed Zope 2.8 is probably unusable on Windows (I haven't tried this since last October -- don't see a point so long as the 1728 bug remains): http://www.zope.org/Collectors/Zope/1507
Tim Peters wrote:
[Christian Theune] ...
I have a compiled Zope 2.8a2 around here, but I'm not able to run the unit tests on it and I'm not willing to publish it therefore because I have the suspicion that this branch never has seen windows before except the one pass of unit tests before 2.8a1.
FYI, I usually run the Zope trunk tests once a day, on WinXP. None of this goes thru WinBuilders, though -- this is doing "test.py -vv --all" from the root of a trunk checkout immediately after "setup.py build_ext -i".
AFAICS the problem is that *everybody* runs the tests in-place. So nobody tests if setup.py installs Zope correctly and people often forget to make sure setup.py installs newly added packages and files. Cheers, Yuppie
participants (5)
-
Christian Theune -
Lennart Regebro -
Mark Hammond -
Tim Peters -
yuppie