Request for commit access for updating zope.sendmail
Hi! I have recently been doing a lot of work on zope.sendmail, and would like to commit a lot of fixes, namely for: 1) Handling of SMTP error 451 etc. 2) Cleaning stale lock links out of the queue 3) Handling Server disconnection 4) Handling of connect() failure The above are fixes for Bug #157104 https://bugs.launchpad.net/zope3/+bug/157104 5) A bit of a clean up QueueProcessorThread so that it complies with IMailQueueProcessor in interfaces.py This is a condition were Zope is restarted - there is a little bit of a race here with duplicate messages where if the zope.sendmail delivery thread exits for some reason after a successful SMTP delivery and has not yet removed the lock link, but that has such a small chance of happening - compared to all the other faults in zope.sendmail this is minor ... I would be willing to become the maintainer for zope.sendmail Best Regards, Matthew Grant
Hi Matthew, On Fri, 2008-01-25 at 09:51 +1300, Matthew Grant wrote:
Hi!
I have recently been doing a lot of work on zope.sendmail, and would like to commit a lot of fixes, namely for:
1) Handling of SMTP error 451 etc. 2) Cleaning stale lock links out of the queue 3) Handling Server disconnection 4) Handling of connect() failure
The above are fixes for Bug #157104 https://bugs.launchpad.net/zope3/+bug/157104
5) A bit of a clean up QueueProcessorThread so that it complies with IMailQueueProcessor in interfaces.py
This all looks very cool. In order to become a zope contributor I believe this FAQ [1] is still valid and requires firstly to send a signed copy of this agreement [2] to the Zope Corporation. (I'm sure I'll be corrected if this has changed). [1] http://www.zope.org/DevHome/Subversion/ContributorFAQ [2] http://dev.zope.org/Subversion/Contributor.pdf HTH. Best regards, Darryl Cousins
This is a condition were Zope is restarted - there is a little bit of a race here with duplicate messages where if the zope.sendmail delivery thread exits for some reason after a successful SMTP delivery and has not yet removed the lock link, but that has such a small chance of happening - compared to all the other faults in zope.sendmail this is minor ...
I would be willing to become the maintainer for zope.sendmail
Best Regards,
Matthew Grant _______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Darryl Cousins wrote:
Hi Matthew,
On Fri, 2008-01-25 at 09:51 +1300, Matthew Grant wrote:
Hi!
I have recently been doing a lot of work on zope.sendmail, and would like to commit a lot of fixes, namely for:
1) Handling of SMTP error 451 etc. 2) Cleaning stale lock links out of the queue 3) Handling Server disconnection 4) Handling of connect() failure
The above are fixes for Bug #157104 https://bugs.launchpad.net/zope3/+bug/157104
5) A bit of a clean up QueueProcessorThread so that it complies with IMailQueueProcessor in interfaces.py
This all looks very cool. In order to become a zope contributor I believe this FAQ [1] is still valid and requires firstly to send a signed copy of this agreement [2] to the Zope Corporation. (I'm sure I'll be corrected if this has changed).
[1] http://www.zope.org/DevHome/Subversion/ContributorFAQ [2] http://dev.zope.org/Subversion/Contributor.pdf
Please include name of an existing contributor who is familiar with you and your work. (Based on Jim's mail: http://mail.zope.org/pipermail/zope-dev/2007-September/029734.html) Regards, Baiju M
Darryl Cousins, on 2008-01-24:
Hi Matthew,
On Fri, 2008-01-25 at 09:51 +1300, Matthew Grant wrote:
Hi!
I have recently been doing a lot of work on zope.sendmail, and would like to commit a lot of fixes, namely for:
1) Handling of SMTP error 451 etc. 2) Cleaning stale lock links out of the queue 3) Handling Server disconnection 4) Handling of connect() failure
The above are fixes for Bug #157104 https://bugs.launchpad.net/zope3/+bug/157104
5) A bit of a clean up QueueProcessorThread so that it complies with IMailQueueProcessor in interfaces.py
This all looks very cool. In order to become a zope contributor I believe this FAQ [1] is still valid and requires firstly to send a signed copy of this agreement [2] to the Zope Corporation. (I'm sure I'll be corrected if this has changed).
[1] http://www.zope.org/DevHome/Subversion/ContributorFAQ [2] http://dev.zope.org/Subversion/Contributor.pdf
I was just looking for these things today as I am pondering becoming a contributor myself. For starters I am missing Dutch translations. Anyway, I found this more recent committer agreement: http://foundation.zope.org/agreements/ZopeFoundation_Committer_Agreement.pdf I suggest you use that one. -- Maurits van Rees | http://maurits.vanrees.org/ Work | http://zestsoftware.nl/ "This is your day, don't let them take it away." [Barlow Girl]
On Friday 25 January 2008, Maurits van Rees wrote:
Anyway, I found this more recent committer agreement:
http://foundation.zope.org/agreements/ZopeFoundation_Committer_Agreement.pd f
I suggest you use that one.
No, the other one is correct. The code has not been transferred to the ZF yet, so this agreement is no good. Regards, Stephan -- Stephan Richter Web Software Design, Development and Training Google me. "Zope Stephan Richter"
participants (5)
-
Baiju M -
Darryl Cousins -
Matthew Grant -
Maurits van Rees -
Stephan Richter