How to report stuff with the collector down?
Hi all! I tried to figure out how to report bugs and stuff without the collector, but couldn't find anything. Any official way? Anyway, I found this minor bug in FileStorage.py. If you try to pack a db with a packdate that is earlier than the date of the first object in the database, you get a "Errno 22, Invalid argument" error. This is because read_index bails out already at the first object and returns position 4L. Whe _reduntant_pack then tries to seek(-8) it of course fails. Now, I haven't tried tha absolute latest versions of Zope, but a check in the CVS indicated that the problem is still there. I chenged this part of FileStorage.py (row 1275 in v1.71.2.3): packpos, maxoid, ltid = read_index( file, name, index, vindex, tindex, stop, read_only=1, ) if self._redundant_pack(file, packpos): raise FileStorageError, ( 'The database has already been packed to a later time\n' 'or no changes have been made since the last pack') to this: packpos, maxoid, ltid = read_index( file, name, index, vindex, tindex, stop, read_only=1, ) if packpos == 4L or self._redundant_pack(file, packpos): raise FileStorageError, ( 'The database has already been packed to a later time\n' 'or no changes have been made since the last pack') Note the "if packpos == 4l or" part. This means that you get the message that it's already packed. I have also some other small "improvements" (on MailHost, f ex) that I'd like to submit to the community. Well, *I* think it's an improvement. :-)
Hi Lennart, I suggest sending your plea for bug reporting as well as the bugfixes themselves to Ken Manheimer (klm@zope.com). He is the person responsible for creating the replacement for the collector. Thanks for the bugfixes! - C ----- Original Message ----- From: "Lennart Regebro" <lennart@regebro.nu> To: <zope-dev@zope.org> Sent: Tuesday, October 16, 2001 4:22 PM Subject: [Zope-dev] How to report stuff with the collector down?
Hi all!
I tried to figure out how to report bugs and stuff without the collector, but couldn't find anything. Any official way?
Anyway, I found this minor bug in FileStorage.py. If you try to pack a db with a packdate that is earlier than the date of the first object in the database, you get a "Errno 22, Invalid argument" error. This is because read_index bails out already at the first object and returns position 4L. Whe _reduntant_pack then tries to seek(-8) it of course fails. Now, I haven't tried tha absolute latest versions of Zope, but a check in the CVS indicated that the problem is still there.
I chenged this part of FileStorage.py (row 1275 in v1.71.2.3):
packpos, maxoid, ltid = read_index( file, name, index, vindex, tindex, stop, read_only=1, )
if self._redundant_pack(file, packpos): raise FileStorageError, ( 'The database has already been packed to a later time\n' 'or no changes have been made since the last pack')
to this:
packpos, maxoid, ltid = read_index( file, name, index, vindex, tindex, stop, read_only=1, )
if packpos == 4L or self._redundant_pack(file, packpos): raise FileStorageError, ( 'The database has already been packed to a later time\n' 'or no changes have been made since the last pack')
Note the "if packpos == 4l or" part. This means that you get the message that it's already packed.
I have also some other small "improvements" (on MailHost, f ex) that I'd like to submit to the community. Well, *I* think it's an improvement. :-)
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
So what is going on with the Collector, its been what a month now? Cheers. -- Andy McKay. ----- Original Message ----- From: "Chris McDonough" <chrism@zope.com> To: "Lennart Regebro" <lennart@regebro.nu>; <zope-dev@zope.org> Sent: Tuesday, October 16, 2001 2:09 PM Subject: Re: [Zope-dev] How to report stuff with the collector down?
Hi Lennart,
I suggest sending your plea for bug reporting as well as the bugfixes themselves to Ken Manheimer (klm@zope.com). He is the person responsible for creating the replacement for the collector.
Thanks for the bugfixes!
- C
----- Original Message ----- From: "Lennart Regebro" <lennart@regebro.nu> To: <zope-dev@zope.org> Sent: Tuesday, October 16, 2001 4:22 PM Subject: [Zope-dev] How to report stuff with the collector down?
Hi all!
I tried to figure out how to report bugs and stuff without the collector, but couldn't find anything. Any official way?
Anyway, I found this minor bug in FileStorage.py. If you try to pack a db with a packdate that is earlier than the date of the first object in the database, you get a "Errno 22, Invalid argument" error. This is because read_index bails out already at the first object and returns position 4L. Whe _reduntant_pack then tries to seek(-8) it of course fails. Now, I haven't tried tha absolute latest versions of Zope, but a check in the CVS indicated that the problem is still there.
I chenged this part of FileStorage.py (row 1275 in v1.71.2.3):
packpos, maxoid, ltid = read_index( file, name, index, vindex, tindex, stop, read_only=1, )
if self._redundant_pack(file, packpos): raise FileStorageError, ( 'The database has already been packed to a later time\n' 'or no changes have been made since the last pack')
to this:
packpos, maxoid, ltid = read_index( file, name, index, vindex, tindex, stop, read_only=1, )
if packpos == 4L or self._redundant_pack(file, packpos): raise FileStorageError, ( 'The database has already been packed to a later time\n' 'or no changes have been made since the last pack')
Note the "if packpos == 4l or" part. This means that you get the message that it's already packed.
I have also some other small "improvements" (on MailHost, f ex) that I'd like to submit to the community. Well, *I* think it's an improvement. :-)
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
On Tue, 16 Oct 2001, Andy McKay wrote:
So what is going on with the Collector, its been what a month now?
See http://dev.zope.org/Wikis/DevSite/Projects/CollectorReplacement/CurrentStatu... for current status. In fact, i'm hoping to have something to test tomorrow. -- Ken klm@zope.com
On Tue, 16 Oct 2001, Ken Manheimer wrote:
On Tue, 16 Oct 2001, Andy McKay wrote:
So what is going on with the Collector, its been what a month now?
See http://dev.zope.org/Wikis/DevSite/Projects/CollectorReplacement/CurrentStatu... for current status.
In fact, i'm hoping to have something to test tomorrow.
I've set up the new collector on new.zope.org, so anyone with an account there can create one and try it out. There are a few small (probably quick fix) but crippling bugs - most notably malfunctioning full-text search - which i don't have time to fix before leaving for some R&R, so it's definitely not yet ready for prime time. I expect to get to them on monday, and have them solved soon after - and maybe people in the know will look at the issue collection i assembled in http://new.zope.org/Members/klm/ColDev and have some answers ready for me when i return...-) If you create a tracker of your own, you can try out the workflow - i'm pretty keen on what's possible with that kind of facility. For the whole picture, do a CVS checkout of the CMF and install the collector in a site of your own - there's an INSTALL.txt in the product directory with instructions. Visit the portal_workflow tool in your portal, and examine the collector_issue_workflow. Lotsa potential. Feel free to add reports of substantial bugs in the collector i mention above, as long as they're not mentioned in existing issues - which, in the absence of full text search, means scanning the existing ones... -- Ken klm@zope.com
In the current version of STX, the underline symbology is not very good for documenting Python. In the string "python_function1 does this, and python_function2 does that", "function1 does this, and python" gets underlined. I think it would be better if either: 1) there are no spaces in strings to underline, only more '_' (_this_is_an_example_), or 2) the final "_" should be followed by whitespace or punctuation. --- Alastair
I checked in some fixes to underline handling into the trunk and the 2.4 branch. Please check this out. If the problems persist, please send me a small testcase. Andreas ----- Original Message ----- From: "Alastair Burt" <burt@dfki.de> To: <zope-dev@zope.org> Sent: Friday, October 19, 2001 06:25 Subject: [Zope-dev] STX and underline symbology
In the current version of STX, the underline symbology is not very good for documenting Python. In the string "python_function1 does this, and python_function2 does that", "function1 does this, and python" gets underlined. I think it would be better if either:
1) there are no spaces in strings to underline, only more '_' (_this_is_an_example_), or
2) the final "_" should be followed by whitespace or punctuation.
--- Alastair
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
"Andreas Jung" <andreas@andreas-jung.com> writes:
I checked in some fixes to underline handling into the trunk and the 2.4 branch. Please check this out. If the problems persist, please send me a small testcase.
I don't really know my way around CVS. The version I checked out has the following in DocumentClass.py: def doc_underline(self, s, #expr=re.compile(r"\_([a-zA-Z0-9\s\.,\?]+)\_").search, # old expr, inconsistent punc, failed to cross newlines expr=re.compile(r'_([%s%s%s\s]+)_' % (letters, digits, under_punc)).search): result = expr(s) if result: if result.group(1)[:1] == '_': return None # no double unders start,end = result.span(1) st,e = result.span() return (StructuredTextUnderline(s[start:end]),st,e) else: return None And this does what I said in my message: python_function1 does this, and python_function2 does that becomes: <p>python<u>function1 does this, and python</u>function2 does that</p> --- Alastair P.S. The following would support alternative 2 in my original message: def doc_underline(self, s, #expr=re.compile(r"\_([a-zA-Z0-9\s\.,\?]+)\_").search, # old expr, inconsistent punc, failed to cross newlines expr=re.compile(r'_([%s%s%s\s]+)_[\s%s]' % (letters, digits, under_punc, phrase_delimiters)).search): result = expr(s) if result: if result.group(1)[:1] == '_': return None # no double unders start,end = result.span(1) return (StructuredTextUnderline(s[start:end]), start-1, end+1) else: return None
On 19 Oct 2001, Alastair Burt wrote:
1) there are no spaces in strings to underline, only more '_' (_this_is_an_example_), or
I'd vote for this. I think it makes underlining more visual when reading the stx in text mode. --RDM
Feel free to provide a patch and unittests *wink* Andreas ----- Original Message ----- From: "R. David Murray" <bitz@bitdance.com> To: "Alastair Burt" <burt@dfki.de> Cc: <zope-dev@zope.org> Sent: Tuesday, October 23, 2001 15:47 Subject: Re: [Zope-dev] STX and underline symbology
On 19 Oct 2001, Alastair Burt wrote:
1) there are no spaces in strings to underline, only more '_' (_this_is_an_example_), or
I'd vote for this. I think it makes underlining more visual when reading the stx in text mode.
--RDM
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
"Andreas Jung" <andreas@zope.com> writes:
Feel free to provide a patch and unittests *wink*
I was about to send a patch, but as I was putting it through its paces, I realised that, depending on the ordering of the list 'DocumentClass.text_types', I could either underline emphasised text (*_foo_*) or emphasise underlined text (_*foo*_) but not both. My brief examination of the code leads me to think this must be the case for all nested colorisation: you can nest a colorisation within one that occurs earlier in text_types but in one that occurs later. Am I correct? --- Alastair
I assume you are right but I have not tried it yet. Andreas ----- Original Message ----- From: "Alastair Burt" <burt@dfki.de> To: "Andreas Jung" <andreas@zope.com> Cc: "R. David Murray" <bitz@bitdance.com>; <zope-dev@zope.org> Sent: Wednesday, October 24, 2001 08:14 Subject: [Zope-dev] STX and nested colorising (was underline symbology)
"Andreas Jung" <andreas@zope.com> writes:
Feel free to provide a patch and unittests *wink*
I was about to send a patch, but as I was putting it through its paces, I realised that, depending on the ordering of the list 'DocumentClass.text_types', I could either underline emphasised text (*_foo_*) or emphasise underlined text (_*foo*_) but not both. My brief examination of the code leads me to think this must be the case for all nested colorisation: you can nest a colorisation within one that occurs earlier in text_types but in one that occurs later. Am I correct?
--- Alastair
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
participants (8)
-
Alastair Burt -
Andreas Jung -
Andreas Jung -
Andy McKay -
Chris McDonough -
Ken Manheimer -
Lennart Regebro -
R. David Murray