Tres, I'd very much appreciate your opinion on http://mail.zope.org/pipermail/zope-dev/2005-January/024237.html http://mail.zope.org/pipermail/zope-dev/2005-January/024242.html Plone is breaking left and right and I gotta do something about it... Thanks, Stefan -- The time has come to start talking about whether the emperor is as well dressed as we are supposed to think he is. /Pete McBreen/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan H. Holek wrote: | I'd very much appreciate your opinion on | http://mail.zope.org/pipermail/zope-dev/2005-January/024237.html | http://mail.zope.org/pipermail/zope-dev/2005-January/024242.html | | Plone is breaking left and right and I gotta do something about it... Please try applying the attached patch to Zope, and then switch to run Zope with the Python security policy. E.g.: ~ $ cd /path/to/software_home ~ $ patch -p0 /tmp/cmf-318-impl-python.patch ~ $ cd /path/to/instance_home ~ $ echo 'security-policy-implementation python' >> zope.conf ~ $ bin/zopectl restart This patch makes the CMF 1.4 tests pass for me. Tres. - -- =============================================================== Tres Seaver tseaver@zope.com Zope Corporation "Zope Dealers" http://www.zope.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCDT5GGqWXf00rNCgRAgLoAJ4tKOIsHJSQvOTmZnWtJIH0W41xBQCeNvB9 6DNd/6hczgu3xrYQtFjHMUY= =rqsj -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan H. Holek wrote: | I'd very much appreciate your opinion on | http://mail.zope.org/pipermail/zope-dev/2005-January/024237.html | http://mail.zope.org/pipermail/zope-dev/2005-January/024242.html | | Plone is breaking left and right and I gotta do something about it... I've checked that patch in on your 'shh-aq_tests-branch', where it makes all tests pass. Please let me know by Monday (if possible) if the patch does *not* clear up the issues you find in Plone. If I don't hear of such outstanding problems, I will port the change to C by Monday noon (GMT-5). Tres. - -- =============================================================== Tres Seaver tseaver@zope.com Zope Corporation "Zope Dealers" http://www.zope.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCDUPTGqWXf00rNCgRAtjFAJ97ipwfbbAYIV5aJQReIw1zB+b5cgCghYFS iu3w1iX16aampEQMOLR1CQ0= =n+yb -----END PGP SIGNATURE-----
Hi Tres, Yes, this makes the checked in tests pass. This just means I did not check in enough tests yet though ;-) I have added tests to 'shh-aqtests-branch' that demonstrate Richard Jones' use case of acquiring a simple type (string). These tests still fail. I have also added tests to CMFDefault on CMF 1.4 branch that show how getToolByName suffers from a similar fate as direct acquisition. Again, everything passes fine in Zope 2.7.2. Thanks, Stefan On 12. Feb 2005, at 00:46, Tres Seaver wrote:
I've checked that patch in on your 'shh-aq_tests-branch', where it makes all tests pass. Please let me know by Monday (if possible) if the patch does *not* clear up the issues you find in Plone.
-- The time has come to start talking about whether the emperor is as well dressed as we are supposed to think he is. /Pete McBreen/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan H. Holek wrote: | Yes, this makes the checked in tests pass. This just means I did not | check in enough tests yet though ;-) | | I have added tests to 'shh-aqtests-branch' that demonstrate Richard | Jones' use case of acquiring a simple type (string). These tests still | fail. | | I have also added tests to CMFDefault on CMF 1.4 branch that show how | getToolByName suffers from a similar fate as direct acquisition. | | Again, everything passes fine in Zope 2.7.2. Jim and I worked on an alternative fix today -- he will be checking it in to your branch shortly, including modifying cAccessControl. Please test further. Tres. - -- =============================================================== Tres Seaver tseaver@zope.com Zope Corporation "Zope Dealers" http://www.zope.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCEO3LGqWXf00rNCgRAvJwAJ9b8e66ErvxyZgvLDsEanOET7QT+QCgmULQ WPts59aaDrkhGIZk05Ui0KU= =xXu0 -----END PGP SIGNATURE-----
Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Stefan H. Holek wrote:
| Yes, this makes the checked in tests pass. This just means I did not | check in enough tests yet though ;-) | | I have added tests to 'shh-aqtests-branch' that demonstrate Richard | Jones' use case of acquiring a simple type (string). These tests still | fail. | | I have also added tests to CMFDefault on CMF 1.4 branch that show how | getToolByName suffers from a similar fate as direct acquisition. | | Again, everything passes fine in Zope 2.7.2.
Jim and I worked on an alternative fix today -- he will be checking it in to your branch shortly, including modifying cAccessControl.
Done. Jim -- Jim Fulton mailto:jim@zope.com Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporation http://www.zope.com http://www.zope.org
Most excellent fix, thanks! Stefan On 14. Feb 2005, at 20:24, Jim Fulton wrote:
Tres Seaver wrote:
Jim and I worked on an alternative fix today -- he will be checking it in to your branch shortly, including modifying cAccessControl.
Done.
Jim
-- Software Engineering is Programming when you can't. --E. W. Dykstra
Oops, I just noticed there is a CMFCore test failing now, all branches... ====================================================================== ERROR: test_move_cant_create_target_metatype_not_allowed (CMFCore.tests.test_PortalFolder.PortalFolderCopySupportTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/stefan/autotest/temp/python23-zope27-cmf15/Products/CMFCore/ tests/test_PortalFolder.py", line 1021, in test_move_cant_create_target_metatype_not_allowed , ce_regex='Insufficient Privileges' File "/Users/stefan/autotest/temp/python23-zope27-cmf15/Products/CMFCore/ tests/test_PortalFolder.py", line 855, in _assertCopyErrorUnauth callable( *args, **kw ) File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ CopySupport.py", line 160, in manage_pasteObjects self._verifyObjectPaste(ob, validate_src=op+1) File "/Users/stefan/autotest/temp/python23-zope27-cmf15/Products/CMFCore/ PortalFolder.py", line 533, in _verifyObjectPaste PortalFolder.inheritedAttribute( File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ CopySupport.py", line 358, in _verifyObjectPaste method = self.restrictedTraverse(method_name) File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ Traversable.py", line 204, in restrictedTraverse return self.unrestrictedTraverse(path, default, restricted=1) File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ Traversable.py", line 180, in unrestrictedTraverse o = guarded_getattr(object, name, M) AttributeError: manage_addFile On 15. Feb 2005, at 21:29, Stefan H. Holek wrote:
Most excellent fix, thanks!
Stefan
On 14. Feb 2005, at 20:24, Jim Fulton wrote:
Tres Seaver wrote:
Jim and I worked on an alternative fix today -- he will be checking it in to your branch shortly, including modifying cAccessControl.
Done.
Jim
-- Software Engineering is Programming when you can't. --E. W. Dykstra
This is a spurious failure. Someone forgot to check in a fix to this test that I checked in on the branch. Jim Stefan H. Holek wrote:
Oops, I just noticed there is a CMFCore test failing now, all branches...
====================================================================== ERROR: test_move_cant_create_target_metatype_not_allowed (CMFCore.tests.test_PortalFolder.PortalFolderCopySupportTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/stefan/autotest/temp/python23-zope27-cmf15/Products/CMFCore/ tests/test_PortalFolder.py", line 1021, in test_move_cant_create_target_metatype_not_allowed , ce_regex='Insufficient Privileges' File "/Users/stefan/autotest/temp/python23-zope27-cmf15/Products/CMFCore/ tests/test_PortalFolder.py", line 855, in _assertCopyErrorUnauth callable( *args, **kw ) File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ CopySupport.py", line 160, in manage_pasteObjects self._verifyObjectPaste(ob, validate_src=op+1) File "/Users/stefan/autotest/temp/python23-zope27-cmf15/Products/CMFCore/ PortalFolder.py", line 533, in _verifyObjectPaste PortalFolder.inheritedAttribute( File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ CopySupport.py", line 358, in _verifyObjectPaste method = self.restrictedTraverse(method_name) File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ Traversable.py", line 204, in restrictedTraverse return self.unrestrictedTraverse(path, default, restricted=1) File "/Users/stefan/autotest/temp/python23-zope27/lib/python/OFS/ Traversable.py", line 180, in unrestrictedTraverse o = guarded_getattr(object, name, M) AttributeError: manage_addFile
On 15. Feb 2005, at 21:29, Stefan H. Holek wrote:
Most excellent fix, thanks!
Stefan
On 14. Feb 2005, at 20:24, Jim Fulton wrote:
Tres Seaver wrote:
Jim and I worked on an alternative fix today -- he will be checking it in to your branch shortly, including modifying cAccessControl.
Done.
Jim
-- Software Engineering is Programming when you can't. --E. W. Dykstra
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
-- Jim Fulton mailto:jim@zope.com Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporation http://www.zope.com http://www.zope.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jim Fulton wrote: | This is a spurious failure. Someone forgot to check in | a fix to this test that I checked in on the branch. | | Jim | | Stefan H. Holek wrote: | |> Oops, I just noticed there is a CMFCore test failing now, all |> branches... This test is isomorphic to the fixed one in OFS.tests.testCopySupport. I will repair it. Tres. - -- =============================================================== Tres Seaver tseaver@zope.com Zope Corporation "Zope Dealers" http://www.zope.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCFP4yGqWXf00rNCgRAs7NAJ9AaFDX6pb5uFjyS0ZiOkx0h91GLQCeK40N deZyPkbsCGNRnnycFH0/ujI= =SelV -----END PGP SIGNATURE-----
participants (3)
-
Jim Fulton -
Stefan H. Holek -
Tres Seaver