zope.testing 3.8 fails in mysterious ways
Hi, I'm running the plone.z3cform tests in a Zope 2.10 instance with zope.testing 3.8 installed. All other tests seem to work OK, but with plone.z3cform's tests, I get: $ ./bin/instance test -s plone.z3cform Running tests at level 1 Running plone.z3cform.testing_zcml_layer tests: Set up plone.z3cform.testing_zcml_layer in 0.972 seconds. Running: .......................... Ran 26 tests with 0 failures and 0 errors in 0.219 seconds. Running zope.testing.testrunner.layer.UnitTests tests: Tear down plone.z3cform.testing_zcml_layer ... not supported Exception in thread Thread-1: Traceback (most recent call last): File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", line 442, in __bootstrap self.run() File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", line 422, in run self.__target(*self.__args, **self.__kwargs) File "/Users/optilude/.buildout/eggs/zope.testing-3.8.0-py2.4.egg/zope/testing/testrunner/runner.py", line 418, in spawn_layer_in_subprocess while nfail > 0: UnboundLocalError: local variable 'nfail' referenced before assignment Total: 26 tests, 0 failures, 0 errors in 5.626 seconds. The tests are here: http://svn.zope.org/repos/main/plone.z3cform/trunk/plone/z3cform/tests.py Any ideas? Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Martin Aspeli wrote:
Hi,
I'm running the plone.z3cform tests in a Zope 2.10 instance with zope.testing 3.8 installed.
All other tests seem to work OK, but with plone.z3cform's tests, I get:
$ ./bin/instance test -s plone.z3cform Running tests at level 1 Running plone.z3cform.testing_zcml_layer tests: Set up plone.z3cform.testing_zcml_layer in 0.972 seconds. Running: .......................... Ran 26 tests with 0 failures and 0 errors in 0.219 seconds. Running zope.testing.testrunner.layer.UnitTests tests: Tear down plone.z3cform.testing_zcml_layer ... not supported Exception in thread Thread-1: Traceback (most recent call last): File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", line 442, in __bootstrap self.run() File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", line 422, in run self.__target(*self.__args, **self.__kwargs) File "/Users/optilude/.buildout/eggs/zope.testing-3.8.0-py2.4.egg/zope/testing/testrunner/runner.py", line 418, in spawn_layer_in_subprocess while nfail > 0: UnboundLocalError: local variable 'nfail' referenced before assignment
Total: 26 tests, 0 failures, 0 errors in 5.626 seconds.
The tests are here: http://svn.zope.org/repos/main/plone.z3cform/trunk/plone/z3cform/tests.py
Any ideas?
I would just use the version of zope.testing which shipped with Zope 2.10? That would be 3.0, I think: $ svn propget svn:externals \ projects/Zope-CVS/Zope-2.10-branch/lib/python/zope | grep testing testing \ svn://svn.zope.org/repos/main/zope.testing/tags/3.0/src/zope/testing Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKcdyK+gerLs4ltQ4RApNjAJoCIJ4hNx08eF/PKj3y/L051dUkhwCeLN7K K3q1e+tiIaUghczSiE95dYc= =3033 -----END PGP SIGNATURE-----
Tres Seaver wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Martin Aspeli wrote:
Hi,
I'm running the plone.z3cform tests in a Zope 2.10 instance with zope.testing 3.8 installed.
All other tests seem to work OK, but with plone.z3cform's tests, I get:
$ ./bin/instance test -s plone.z3cform Running tests at level 1 Running plone.z3cform.testing_zcml_layer tests: Set up plone.z3cform.testing_zcml_layer in 0.972 seconds. Running: .......................... Ran 26 tests with 0 failures and 0 errors in 0.219 seconds. Running zope.testing.testrunner.layer.UnitTests tests: Tear down plone.z3cform.testing_zcml_layer ... not supported Exception in thread Thread-1: Traceback (most recent call last): File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", line 442, in __bootstrap self.run() File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", line 422, in run self.__target(*self.__args, **self.__kwargs) File "/Users/optilude/.buildout/eggs/zope.testing-3.8.0-py2.4.egg/zope/testing/testrunner/runner.py", line 418, in spawn_layer_in_subprocess while nfail > 0: UnboundLocalError: local variable 'nfail' referenced before assignment
Total: 26 tests, 0 failures, 0 errors in 5.626 seconds.
The tests are here: http://svn.zope.org/repos/main/plone.z3cform/trunk/plone/z3cform/tests.py
Any ideas?
I would just use the version of zope.testing which shipped with Zope 2.10? That would be 3.0, I think:
$ svn propget svn:externals \ projects/Zope-CVS/Zope-2.10-branch/lib/python/zope | grep testing testing \ svn://svn.zope.org/repos/main/zope.testing/tags/3.0/src/zope/testing
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine. Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book
On Thu, Jul 30, 2009 at 9:33 PM, Martin Aspeli<optilude+lists@gmail.com> wrote:
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine.
The traceback you pasted shows an UnboundLocalError. What about looking at the source and figuring out why that local variable is not defined? -- Sidnei
Sidnei da Silva wrote:
On Thu, Jul 30, 2009 at 9:33 PM, Martin Aspeli<optilude+lists@gmail.com> wrote:
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine.
The traceback you pasted shows an UnboundLocalError. What about looking at the source and figuring out why that local variable is not defined?
-- Sidnei
I bumped into the same bug while working on the same package... I allowed myself to add the missing assignment. However, I'd like someone to check over my shoulder. http://mail.zope.org/pipermail/checkins/2009-July/036586.html Further, this bug is triggered by another one happening when running tests with buildout in plone.z3cform current trunk (r102411). The test runner is trying to spawn a subprocess with the --resume-layer argument. However, the --resume-layer argument is not accepted by the subprocess. This produces an error in a format not foreseen by the error parser. (which then triggered the UnboundLocalError). It would be nice if someone with a better understanding of the testrunner could take a look and understand why the --resume-layer stuff happens. Christian ? -- Godefroid Chapelle (aka __gotcha) http://bubblenet.be
On 08/01/2009 01:35 AM, Godefroid Chapelle wrote:
Sidnei da Silva wrote:
On Thu, Jul 30, 2009 at 9:33 PM, Martin Aspeli<optilude+lists@gmail.com> wrote:
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine.
The traceback you pasted shows an UnboundLocalError. What about looking at the source and figuring out why that local variable is not defined?
-- Sidnei
I bumped into the same bug while working on the same package...
I allowed myself to add the missing assignment. However, I'd like someone to check over my shoulder. http://mail.zope.org/pipermail/checkins/2009-July/036586.html
Further, this bug is triggered by another one happening when running tests with buildout in plone.z3cform current trunk (r102411).
The test runner is trying to spawn a subprocess with the --resume-layer argument. However, the --resume-layer argument is not accepted by the subprocess.
This produces an error in a format not foreseen by the error parser. (which then triggered the UnboundLocalError).
It would be nice if someone with a better understanding of the testrunner could take a look and understand why the --resume-layer stuff happens. Christian ?
Can you make a bug out of that? I won't be able to look at it for a while but I'd also not have it forgotten. Christian -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development
Christian Theune wrote:
On 08/01/2009 01:35 AM, Godefroid Chapelle wrote:
Sidnei da Silva wrote:
On Thu, Jul 30, 2009 at 9:33 PM, Martin Aspeli<optilude+lists@gmail.com> wrote:
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine. The traceback you pasted shows an UnboundLocalError. What about looking at the source and figuring out why that local variable is not defined?
-- Sidnei I bumped into the same bug while working on the same package...
I allowed myself to add the missing assignment. However, I'd like someone to check over my shoulder. http://mail.zope.org/pipermail/checkins/2009-July/036586.html
Further, this bug is triggered by another one happening when running tests with buildout in plone.z3cform current trunk (r102411).
The test runner is trying to spawn a subprocess with the --resume-layer argument. However, the --resume-layer argument is not accepted by the subprocess.
This produces an error in a format not foreseen by the error parser. (which then triggered the UnboundLocalError).
It would be nice if someone with a better understanding of the testrunner could take a look and understand why the --resume-layer stuff happens. Christian ?
Can you make a bug out of that? I won't be able to look at it for a while but I'd also not have it forgotten.
Sure. https://bugs.launchpad.net/zope3/+bug/407916 Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book
hi, just fyi: the bug is also present in zope.testing 3.7.7 (showing up when testing plone.z3cform). would it perhaps be possible to release a fixed 3.7.8 soon, so that our buildout stops complaining again? :) cheers, andi Godefroid Chapelle wrote:
Sidnei da Silva wrote:
On Thu, Jul 30, 2009 at 9:33 PM, Martin Aspeli<optilude+lists@gmail.com> wrote:
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine. The traceback you pasted shows an UnboundLocalError. What about looking at the source and figuring out why that local variable is not defined?
-- Sidnei
I bumped into the same bug while working on the same package...
I allowed myself to add the missing assignment. However, I'd like someone to check over my shoulder. http://mail.zope.org/pipermail/checkins/2009-July/036586.html
Further, this bug is triggered by another one happening when running tests with buildout in plone.z3cform current trunk (r102411).
The test runner is trying to spawn a subprocess with the --resume-layer argument. However, the --resume-layer argument is not accepted by the subprocess.
This produces an error in a format not foreseen by the error parser. (which then triggered the UnboundLocalError).
It would be nice if someone with a better understanding of the testrunner could take a look and understand why the --resume-layer stuff happens. Christian ?
-- zeidler it consulting - http://zitc.de/ - info@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.3rc4 released! -- http://plone.org/products/plone/
On Mon, Aug 03, 2009 at 01:17:41PM +0200, Andreas Zeidler wrote:
just fyi: the bug is also present in zope.testing 3.7.7 (showing up when testing plone.z3cform). would it perhaps be possible to release a fixed 3.7.8 soon, so that our buildout stops complaining again? :)
I looked at the bug and Godefroid's checkin today. Things seem to be complicated. Short summary: collective.recipe.z2testrunner doesn't support running tests in a subprocess. Long summary: https://launchpad.net/bugs/407916 As a quick workaround, instead of a single 'run tests' step that does bin/test do separate 'run unit tests' and 'run functional tests' steps bin/test -u bin/test -f in your buildbot config. Marius Gedminas -- http://pov.lt/ -- Zope 3 consulting and development
Marius Gedminas wrote:
On Mon, Aug 03, 2009 at 01:17:41PM +0200, Andreas Zeidler wrote:
just fyi: the bug is also present in zope.testing 3.7.7 (showing up when testing plone.z3cform). would it perhaps be possible to release a fixed 3.7.8 soon, so that our buildout stops complaining again? :)
I looked at the bug and Godefroid's checkin today. Things seem to be complicated. Short summary: collective.recipe.z2testrunner doesn't support running tests in a subprocess. Long summary: https://launchpad.net/bugs/407916
As a quick workaround, instead of a single 'run tests' step that does
bin/test
do separate 'run unit tests' and 'run functional tests' steps
bin/test -u bin/test -f
in your buildbot config.
Marius Gedminas
I did fix zope.testing and plone.recipe.zope2instance : http://mail.zope.org/pipermail/checkins/2009-August/036807.html https://dev.plone.org/collective/changeset/94328/buildout/plone.recipe.zope2... Fixes released in zope.testing 0.8.1 and plone.recipe.zope2instance 3.4 -- Godefroid Chapelle (aka __gotcha) http://bubblenet.be
Sidnei da Silva wrote:
On Thu, Jul 30, 2009 at 9:33 PM, Martin Aspeli<optilude+lists@gmail.com> wrote:
Unfortunately, I've got other packages that depend on a newer zope.testing (specifically, collective.testcaselayer). But I thought zope.testing aimed to be able to run any "valid" tests, so it sounds like a bug in zope.testing regardless, at least since every other test I've run in the same instance work fine.
The traceback you pasted shows an UnboundLocalError. What about looking at the source and figuring out why that local variable is not defined?
Thanks.
participants (7)
-
Andreas Zeidler -
Christian Theune -
Godefroid Chapelle -
Marius Gedminas -
Martin Aspeli -
Sidnei da Silva -
Tres Seaver