Undeclared dependency of zope.site on zope.app.publication
I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site. I'd like to get rid of the dependency of zope.site on zope.app.publisher and I think it would be OK to invert it by moving the relevant ZCML declarations (two event handler registrations) and the two pieces of test regarding traversal behaviour to zope.app.publisher, which would thereby grow a new dependency on zope.site. What do others think? -- Thomas
Am 23.09.2009 um 08:06 schrieb Thomas Lotze:
I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site.
I'd like to get rid of the dependency of zope.site on zope.app.publisher
Do you mean zope.app.publication here and in the following lines?
and I think it would be OK to invert it by moving the relevant ZCML declarations (two event handler registrations) and the two pieces of test regarding traversal behaviour to zope.app.publisher, which would thereby grow a new dependency on zope.site. What do others think?
Yours sincerely, -- Michael Howitz · mh@gocept.com · software developer gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1 Zope and Plone consulting and development
Michael Howitz wrote:
Am 23.09.2009 um 08:06 schrieb Thomas Lotze:
I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site.
I'd like to get rid of the dependency of zope.site on zope.app.publisher
Do you mean zope.app.publication here and in the following lines?
Yes, of course. -- Thomas
Thomas Lotze wrote:
I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site.
I'd like to get rid of the dependency of zope.site on zope.app.publisher and I think it would be OK to invert it by moving the relevant ZCML declarations (two event handler registrations) and the two pieces of test regarding traversal behaviour to zope.app.publisher, which would thereby grow a new dependency on zope.site. What do others think?
At first glance I'm +1 on doing this. We'll need analyze what we can do with zope.app.publication too. Regards, Martijn
Martijn Faassen wrote:
Thomas Lotze wrote:
I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site.
I'd like to get rid of the dependency of zope.site on zope.app.publisher and I think it would be OK to invert it by moving the relevant ZCML declarations (two event handler registrations) and the two pieces of test regarding traversal behaviour to zope.app.publisher, which would thereby grow a new dependency on zope.site. What do others think?
At first glance I'm +1 on doing this. We'll need analyze what we can do with zope.app.publication too.
I've just committed changes to the packages to remove any trace of zope.app.publication from zope.site. The handlers in question are still implemented by zope.site as they are not z.a.p specific, and conditionally registered by z.a.p if zope.site is installed. This makes zope.site a testing dependency of zope.app.publication. Could someone with the appropriate privileges please grant me PyPI access to the two packages so I can make releases? (Though releasing zope.site might wait until another issue involving it has been resolved.) -- Thomas
Hey, Thomas Lotze wrote: [snip]
Could someone with the appropriate privileges please grant me PyPI access to the two packages so I can make releases? (Though releasing zope.site might wait until another issue involving it has been resolved.)
I've given you access to both. Regards, Martijn
participants (3)
-
Martijn Faassen -
Michael Howitz -
Thomas Lotze