zope.app.security 3.5.1 ZCML changes
Someone changed the ZCML that registers the "gopherlib" module (why???) to this: <!-- This package has been deprecated in Python 2.5; let's use a cheap way of detecting Python 2.5 by checking whether the package "regex" exists, which has been deleted in that version. --> <module module="gopherlib" zcml:condition="installed regex"> <allow attributes="send_selection send_query" /> </module> In trying to avoid a Python 2.5 deprecation warning (not removal), this code imports and causes a deprecation warning for a module that was declared obsolete in Python 1.5 (yes, that's a "1"!). Isn't this just a little bit insane? I think the condition should be removed for zope.app.security 3.5.2, and the registration of gopherlib should be removed for 3.6.0. -Fred -- Fred L. Drake, Jr. <fdrake at gmail.com> "Chaos is the score upon which reality is written." --Henry Miller
On Thursday 26 June 2008, Fred Drake wrote:
Someone changed the ZCML that registers the "gopherlib" module (why???) to this:
I did as you were aware of. :-) The gopherlib module was there before, I just shut up the deprecation warning.
<!-- This package has been deprecated in Python 2.5; let's use a cheap way of detecting Python 2.5 by checking whether the package "regex" exists, which has been deleted in that version. --> <module module="gopherlib" zcml:condition="installed regex"> <allow attributes="send_selection send_query" /> </module>
In trying to avoid a Python 2.5 deprecation warning (not removal), this code imports and causes a deprecation warning for a module that was declared obsolete in Python 1.5 (yes, that's a "1"!).
Isn't this just a little bit insane?
A deprecation warning was not issued until Python 2.5 though. How would I know?
I think the condition should be removed for zope.app.security 3.5.2, and the registration of gopherlib should be removed for 3.6.0.
I am not sure why you would want a 3.5.2 release, since nothing breaks. I am all in favor removing this declaration for 3.6.0. Regards, Stephan -- Stephan Richter Web Software Design, Development and Training Google me. "Zope Stephan Richter"
On Thu, Jun 26, 2008 at 12:33 PM, Stephan Richter <srichter@cosmos.phy.tufts.edu> wrote:
I did as you were aware of. :-)
I wasn't, because I didn't look. Note also that I wasn't asking who; I don't think that matters.
The gopherlib module was there before, I just shut up the deprecation warning.
Using Python 2.4.4, I get a deprecation warning for *regex*. So you shut up the deprecation warning for Python 2.5 by introducing one for Python 2.4.
A deprecation warning was not issued until Python 2.5 though. How would I know?
About the gopherlib deprecation? That wasn't deprecated until recently; it was regex that was declared obsolete in 1.5, and 2.4 generates a deprecation warning. I'll take it that you didn't test your change with Python 2.4, which is still the supported Python for Zope 3.4 (whatever that means).
I am not sure why you would want a 3.5.2 release, since nothing breaks. I am all in favor removing this declaration for 3.6.0.
Because of the deprecation warning from the regex module. Deprecation warnings aren't breakages, but when running tests, they can make it a lot harder to see real errors as the output is generated by the test runner. This is especially bad if you have a lot of separate functional testing layers. -Fred -- Fred L. Drake, Jr. <fdrake at gmail.com> "Chaos is the score upon which reality is written." --Henry Miller
On Thursday 26 June 2008, Fred Drake wrote:
The gopherlib module was there before, I just shut up the deprecation warning.
Using Python 2.4.4, I get a deprecation warning for *regex*. So you shut up the deprecation warning for Python 2.5 by introducing one for Python 2.4.
Okay, I did not parse that from your first E-mail. I will fix it and test it in both, Py 2.4 and 2.5. No problemo. Regards, Stephan -- Stephan Richter Web Software Design, Development and Training Google me. "Zope Stephan Richter"
participants (2)
-
Fred Drake -
Stephan Richter