Copyright update for z3c.ajax: no buildout, no headers
Hi, I just fixed up z3c.ajax and it has a quirk that the check doesn't know about: If a file doesn't contain any copyright attribution header, it ignores that file. In this case, z3c.ajax has no headers at all. no setup.py. no buildout. I added the missing license and copyright files to silence the check but I'm relatively sure there's an edge case here. Thoughts? Christian -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development
Hello Christian, Thursday, June 3, 2010, 8:20:10 AM, you wrote: CT> If a file doesn't contain any copyright attribution header, it ignores CT> that file. I'd say rather check for it and warn (unless it's __init__.py). Sh*t can happen easily. -- Best regards, Adam GROSZER mailto:agroszer@gmail.com -- Quote of the day: Violence is permissible even desirable occasionally
On 6/3/10 8:20 AM, Christian Theune wrote:
Hi,
I just fixed up z3c.ajax and it has a quirk that the check doesn't know about:
If a file doesn't contain any copyright attribution header, it ignores that file.
In this case, z3c.ajax has no headers at all. no setup.py. no buildout.
I added the missing license and copyright files to silence the check but I'm relatively sure there's an edge case here.
Thoughts?
Any ideas yet on situations like these? I found several packages now that do not contain any copyright headers in the python modules, or, sometimes they do in the package itself, but not in the package's test modules. I decided to just go ahead for now silencing the check, my reasoning being: if the copyright-checkscript is updated at some point in time to also check for copyright-less modules, we automatically will have list again of project that need fixing in that regard. OK? regards, jw
On 06/04/2010 12:49 PM, Jan-Wijbrand Kolman wrote:
On 6/3/10 8:20 AM, Christian Theune wrote:
Hi,
I just fixed up z3c.ajax and it has a quirk that the check doesn't know about:
If a file doesn't contain any copyright attribution header, it ignores that file.
In this case, z3c.ajax has no headers at all. no setup.py. no buildout.
I added the missing license and copyright files to silence the check but I'm relatively sure there's an edge case here.
Thoughts?
Any ideas yet on situations like these?
I found several packages now that do not contain any copyright headers in the python modules, or, sometimes they do in the package itself, but not in the package's test modules.
I decided to just go ahead for now silencing the check, my reasoning being: if the copyright-checkscript is updated at some point in time to also check for copyright-less modules, we automatically will have list again of project that need fixing in that regard.
OK?
That's what I think and did this morning, too. -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development
participants (3)
-
Adam GROSZER -
Christian Theune -
Jan-Wijbrand Kolman