[Checkins] SVN: z3c.form/trunk/src/z3c/form/browser/widget.py Revert change 103644. The "complicated" algorithm preserves class order, so doctests don't fail.
Vincent Fretin
vincent.fretin at gmail.com
Fri Sep 11 07:34:06 EDT 2009
Hi,
I'm sorry I broke the tests.
But instead of reverting, maybe we can sort the list and fix the doctests?
self.klass = u' '.join(sorted(frozenset(parts)))
It's just an idea, if you don't like it, I'm fine with the current code. :-)
Regards
Vincent
On Fri, Sep 11, 2009 at 11:36 AM, Dan Korostelev <nadako at gmail.com> wrote:
> Log message for revision 103729:
> Revert change 103644. The "complicated" algorithm preserves class order, so doctests don't fail.
>
> Changed:
> U z3c.form/trunk/src/z3c/form/browser/widget.py
>
> -=-
> Modified: z3c.form/trunk/src/z3c/form/browser/widget.py
> ===================================================================
> --- z3c.form/trunk/src/z3c/form/browser/widget.py 2009-09-11 08:45:00 UTC (rev 103728)
> +++ z3c.form/trunk/src/z3c/form/browser/widget.py 2009-09-11 09:36:45 UTC (rev 103729)
> @@ -54,9 +54,16 @@
> if not self.klass:
> self.klass = unicode(klass)
> else:
> - # Make sure items are not repeated.
> - parts = self.klass.split() + [unicode(klass)]
> - self.klass = u' '.join(frozenset(parts))
> + #make sure items are not repeated
> + parts = self.klass.split()+[unicode(klass)]
> + seen = {}
> + unique = []
> + for item in parts:
> + if item in seen:
> + continue
> + seen[item]=1
> + unique.append(item)
> + self.klass = u' '.join(unique)
>
> def update(self):
> """See z3c.form.interfaces.IWidget"""
>
> _______________________________________________
> checkins mailing list
> checkins at zope.org
> https://mail.zope.org/mailman/listinfo/checkins
>
More information about the checkins
mailing list