[Checkins] SVN: lovely.remotetask/trunk/ - Convert logged exceptions to str because log messages should be strings.
Christian Zagrodnick
cz at gocept.com
Wed Apr 14 08:38:58 EDT 2010
Log message for revision 110870:
- Convert logged exceptions to str because log messages should be strings.
Changed:
U lovely.remotetask/trunk/CHANGES.txt
U lovely.remotetask/trunk/src/lovely/remotetask/processor.py
U lovely.remotetask/trunk/src/lovely/remotetask/service.py
-=-
Modified: lovely.remotetask/trunk/CHANGES.txt
===================================================================
--- lovely.remotetask/trunk/CHANGES.txt 2010-04-14 12:38:49 UTC (rev 110869)
+++ lovely.remotetask/trunk/CHANGES.txt 2010-04-14 12:38:58 UTC (rev 110870)
@@ -5,7 +5,7 @@
0.6 (unreleased)
----------------
-- Nothing changed yet.
+- Convert logged exceptions to str because log messages should be strings.
0.5 (2009-09-10)
Modified: lovely.remotetask/trunk/src/lovely/remotetask/processor.py
===================================================================
--- lovely.remotetask/trunk/src/lovely/remotetask/processor.py 2010-04-14 12:38:49 UTC (rev 110869)
+++ lovely.remotetask/trunk/src/lovely/remotetask/processor.py 2010-04-14 12:38:58 UTC (rev 110870)
@@ -94,7 +94,7 @@
except Exception, error:
# This thread should never crash, thus a blank except
log.error('Processor: ``%s()`` caused an error!' %method)
- log.exception(error)
+ log.exception(str(error))
return errorValue is ERROR_MARKER and error or errorValue
def processNext(self, jobid=None):
Modified: lovely.remotetask/trunk/src/lovely/remotetask/service.py
===================================================================
--- lovely.remotetask/trunk/src/lovely/remotetask/service.py 2010-04-14 12:38:49 UTC (rev 110869)
+++ lovely.remotetask/trunk/src/lovely/remotetask/service.py 2010-04-14 12:38:58 UTC (rev 110870)
@@ -244,7 +244,7 @@
jobtask = component.getUtility(self.taskInterface, name=job.task)
except ComponentLookupError, error:
log.error('Task "%s" not found!'% job.task)
- log.exception(error)
+ log.exception(str(error))
job.error = error
if job.status != interfaces.CRONJOB:
job.status = interfaces.ERROR
@@ -265,7 +265,7 @@
if storage.runCount <= 3:
log.error('Caught a generic exception, preventing thread '
'from crashing')
- log.exception(error)
+ log.exception(str(error))
raise
else:
job.error = error
More information about the checkins
mailing list