[Checkins] SVN: zope.testrunner/trunk/src/zope/testrunner/test_subunit.py Fix Windows test failure in test_subunit.py.
Marius Gedminas
marius at pov.lt
Wed Oct 13 19:41:31 EDT 2010
Log message for revision 117532:
Fix Windows test failure in test_subunit.py.
The assertion was for <U+FFFD> immediately followed by '0'.
The actual output was <U+FFFD> followed by '\n' followed by '0'.
I don't know anything about subunit, so I cannot say if I've fixed an
over-eager assertion or papered over a bug. In my defense I'll say that
the other two tests do not test for a '0' immediately following the encoded
character, they just look at the encoded character.
Can someone who knows subunit take a look at this test?
Changed:
U zope.testrunner/trunk/src/zope/testrunner/test_subunit.py
-=-
Modified: zope.testrunner/trunk/src/zope/testrunner/test_subunit.py
===================================================================
--- zope.testrunner/trunk/src/zope/testrunner/test_subunit.py 2010-10-13 16:26:03 UTC (rev 117531)
+++ zope.testrunner/trunk/src/zope/testrunner/test_subunit.py 2010-10-13 23:41:30 UTC (rev 117532)
@@ -47,13 +47,17 @@
exc_info = self.makeByteStringFailure(unichr(6514), 'utf8')
self.subunit_formatter.test_failure(self, 0, exc_info)
assert "AssertionError: \xe1\xa5\xb2" in self.output.getvalue()
+ # '\xe1\xa5\xb2'.decode('utf-8') == unichr(6514)
def test_print_error_containing_utf8_bytestrings(self):
exc_info = self.makeByteStringFailure(unichr(6514), 'utf8')
self.subunit_formatter.test_error(self, 0, exc_info)
assert "AssertionError: \xe1\xa5\xb2" in self.output.getvalue()
+ # '\xe1\xa5\xb2'.decode('utf-8') == unichr(6514)
def test_print_failure_containing_latin1_bytestrings(self):
exc_info = self.makeByteStringFailure(unichr(241), 'latin1')
self.subunit_formatter.test_failure(self, 0, exc_info)
- assert "AssertionError: \xef\xbf\xbd0" in self.output.getvalue()
+ assert "AssertionError: \xef\xbf\xbd" in self.output.getvalue()
+ # '\xef\xbf\xbd'.decode('utf-8') = unichr(0xFFFD)
+
More information about the checkins
mailing list