[Checkins] SVN: Products.CMFCore/trunk/Products/CMFCore/tests/base/testcase.py - catching OSError should be sufficient
Yvo Schubbe
y.2011 at wcm-solutions.de
Sun Feb 6 15:12:50 EST 2011
Log message for revision 120170:
- catching OSError should be sufficient
Changed:
U Products.CMFCore/trunk/Products/CMFCore/tests/base/testcase.py
-=-
Modified: Products.CMFCore/trunk/Products/CMFCore/tests/base/testcase.py
===================================================================
--- Products.CMFCore/trunk/Products/CMFCore/tests/base/testcase.py 2011-02-06 20:09:30 UTC (rev 120169)
+++ Products.CMFCore/trunk/Products/CMFCore/tests/base/testcase.py 2011-02-06 20:12:49 UTC (rev 120170)
@@ -172,12 +172,12 @@
# also make sure the skin folder mod time has changed
try:
dir_mtime = stat(self.skin_path_name).st_mtime
- except: # XXX Why bare except?
+ except OSError:
dir_mtime = 0.0
thePath = join(self.skin_path_name, filename)
try:
mtime1 = stat(thePath).st_mtime
- except: # XXX Why bare except?
+ except OSError:
mtime1 = 0.0
mtime2 = mtime1
while mtime2 == mtime1:
@@ -190,7 +190,7 @@
def _deleteFile(self, filename):
try:
dir_mtime = stat(self.skin_path_name).st_mtime
- except: # XXX Why bare except?
+ except OSError:
dir_mtime = 0.0
remove(join(self.skin_path_name, filename))
self._addedOrRemoved(dir_mtime)
More information about the checkins
mailing list