[Checkins] [zopefoundation/ZODB] f8cf23: Don't manipulate Connection state after it has bee...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/ZODB
  Commit: f8cf23ecd4604740b4389b6f2d2392804b083fb7
      https://github.com/zopefoundation/ZODB/commit/f8cf23ecd4604740b4389b6f2d2392804b083fb7
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-02-01 (Wed, 01 Feb 2017)

  Changed paths:
    M CHANGES.rst
    M src/ZODB/Connection.py

  Log Message:
  -----------
  Don't manipulate Connection state after it has been returned to the pool.

Doing so leads to race conditions.

In particular, there can be an AttributeError.

See https://github.com/zodb/zodbshootout/issues/26 for details.


  Commit: 739761cfd7e77f3afcc6fa8ecd9aea23e35a53de
      https://github.com/zopefoundation/ZODB/commit/739761cfd7e77f3afcc6fa8ecd9aea23e35a53de
  Author: Jim Fulton <jim at jimfulton.info>
  Date:   2017-02-01 (Wed, 01 Feb 2017)

  Changed paths:
    M CHANGES.rst
    M src/ZODB/Connection.py

  Log Message:
  -----------
  Merge pull request #143 from zopefoundation/jam-zodbshootout-26

Don't manipulate Connection state after it has been returned to the pool.

Good catch. Thanks.


Compare: https://github.com/zopefoundation/ZODB/compare/f3b2350ab738...739761cfd7e7