[Checkins] [zopefoundation/persistent] 1fe338: Add failing test for #41
GitHub
noreply at github.com
Wed Aug 1 22:05:55 CEST 2018
Branch: refs/heads/issue41
Home: https://github.com/zopefoundation/persistent
Commit: 1fe3387ef677535b9dc2dbd98467c8662d461230
https://github.com/zopefoundation/persistent/commit/1fe3387ef677535b9dc2dbd98467c8662d461230
Author: Jason Madden <jamadden at gmail.com>
Date: 2018-08-01 (Wed, 01 Aug 2018)
Changed paths:
M persistent/tests/test_timestamp.py
Log Message:
-----------
Add failing test for #41
Commit: 7ccaad4455cf0902b5fa99e543eb45781d8abb91
https://github.com/zopefoundation/persistent/commit/7ccaad4455cf0902b5fa99e543eb45781d8abb91
Author: Jason Madden <jamadden at gmail.com>
Date: 2018-08-01 (Wed, 01 Aug 2018)
Changed paths:
M CHANGES.rst
M persistent/_timestamp.c
M persistent/tests/test_timestamp.py
M persistent/timestamp.py
Log Message:
-----------
Make the C and Python TimeStamp round the same way.
Fixes #41.
The C version now always rounds its seconds value, even when its decoding from a value with lots of noise, as when initially created from 6.123456789. Previously it would return 6.1234567780047655; now it returns 6.123457 which is what it would return after being round-tripped through raw().
The Python version also does this, by (expensively) unpacking the raw value it just computed.
These could both probably be better optimized.
Compare: https://github.com/zopefoundation/persistent/compare/1fe3387ef677^...7ccaad4455cf
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the checkins
mailing list