[CMF-checkins] CVS: Products/CMFCore/tests - test_FSPythonScript.py:1.10

[Jens Vagelpohl]

Update of /cvs-repository/Products/CMFCore/tests
In directory cvs.zope.org:/tmp/cvs-serv28632/CMFCore/tests

Modified Files:
	test_FSPythonScript.py 
Log Message:
- When customizing filesystem objects in the skins tool, some
  security-related settings were not transferred to the customized
  object, namely proxy roles and permission settings.
  (http://www.zope.org/Collectors/CMF/351)


=== Products/CMFCore/tests/test_FSPythonScript.py 1.9 => 1.10 ===
--- Products/CMFCore/tests/test_FSPythonScript.py:1.9	Wed Nov 24 10:12:30 2004
+++ Products/CMFCore/tests/test_FSPythonScript.py	Wed May  4 15:52:13 2005
@@ -9,16 +9,28 @@
 from time import sleep
 
 from OFS.Folder import Folder
+from Products.StandardCacheManagers import RAMCacheManager
 
 from Products.CMFCore.FSPythonScript import FSPythonScript
+from Products.CMFCore.FSMetadata import FSMetadata
 from Products.CMFCore.tests.base.testcase import FSDVTest
+from Products.CMFCore.tests.base.testcase import SecurityTest
 
 
-class FSPythonScriptTests( FSDVTest ):
+class FSPSMaker(FSDVTest):
+
+    def _makeOne( self, id, filename ):
+        path = join(self.skin_path_name, filename)
+        metadata = FSMetadata(path)
+        metadata.read()
+        return FSPythonScript( id, path, properties=metadata.getProperties() ) 
+
+
+class FSPythonScriptTests(FSPSMaker):
 
     def test_GetSize( self ):
         # Test get_size returns correct value
-        script = FSPythonScript('test1', join(self.skin_path_name,'test1.py'))
+        script = self._makeOne('test1', 'test1.py')
         self.assertEqual(len(script.read()),script.get_size())
 
     def testInitializationRaceCondition(self):
@@ -27,7 +39,7 @@
         # object was really parsed.
         for n in range(10):
             f = Folder()
-            script = FSPythonScript('test1', join(self.skin_path_name,'test1.py')).__of__(f)
+            script = self._makeOne('test1', 'test1.py').__of__(f)
             res = []
 
             def call_script(script=script, res=res):
@@ -43,9 +55,95 @@
             self.assertEqual(res, ['test1', 'test1'], res)
 
 
+class FSPythonScriptCustomizationTests(SecurityTest, FSPSMaker):
+
+    def setUp( self ):
+        FSPSMaker.setUp(self)
+        SecurityTest.setUp( self )
+
+        self.root._setObject( 'portal_skins', Folder( 'portal_skins' ) )
+        self.skins = self.root.portal_skins
+
+        self.skins._setObject( 'custom', Folder( 'custom' ) )
+        self.custom = self.skins.custom
+
+        self.skins._setObject( 'fsdir', Folder( 'fsdir' ) )
+        self.fsdir = self.skins.fsdir
+
+        self.fsdir._setObject( 'test6'
+                             , self._makeOne( 'test6', 'test6.py' ) )
+
+        self.fsPS = self.fsdir.test6
+
+    def test_customize( self ):
+
+        self.fsPS.manage_doCustomize( folder_path='custom' )
+
+        self.assertEqual( len( self.custom.objectIds() ), 1 )
+        self.failUnless( 'test6' in self.custom.objectIds() )  
+
+    def test_customize_caching(self):
+        # Test to ensure that cache manager associations survive customizing
+        cache_id = 'gofast'
+        RAMCacheManager.manage_addRAMCacheManager( self.root
+                                                 , cache_id
+                                                 , REQUEST=None
+                                                 )
+        self.fsPS.ZCacheable_setManagerId(cache_id, REQUEST=None)
+
+        self.assertEqual(self.fsPS.ZCacheable_getManagerId(), cache_id)
+
+        self.fsPS.manage_doCustomize(folder_path='custom')
+        custom_ps = self.custom.test6
+
+        self.assertEqual(custom_ps.ZCacheable_getManagerId(), cache_id)
+
+    def test_customize_proxyroles(self):
+        # Test to ensure that proxy roles survive customizing
+        self.fsPS._proxy_roles = ('Manager', 'Anonymous')
+        self.failUnless(self.fsPS.manage_haveProxy('Anonymous'))
+        self.failUnless(self.fsPS.manage_haveProxy('Manager'))
+
+        self.fsPS.manage_doCustomize(folder_path='custom')
+        custom_ps = self.custom.test6
+        self.failUnless(custom_ps.manage_haveProxy('Anonymous'))
+        self.failUnless(custom_ps.manage_haveProxy('Manager'))
+
+    def test_customization_permissions(self):
+        # Test to ensure that permission settings survive customizing
+        perm = 'View management screens'
+
+        # First, set a permission to an odd role and verify
+        self.fsPS.manage_permission( perm
+                                   , roles=('Anonymous',)
+                                   , acquire=0
+                                   )
+        rop = self.fsPS.rolesOfPermission(perm)
+        for rop_info in rop:
+            if rop_info['name'] == 'Anonymous':
+                self.failIf(rop_info['selected'] == '')
+            else:
+                self.failUnless(rop_info['selected'] == '')
+
+        # Now customize and verify again
+        self.fsPS.manage_doCustomize(folder_path='custom')
+        custom_ps = self.custom.test6
+        rop = custom_ps.rolesOfPermission(perm)
+        for rop_info in rop:
+            if rop_info['name'] == 'Anonymous':
+                self.failIf(rop_info['selected'] == '')
+            else:
+                self.failUnless(rop_info['selected'] == '')
+
+    def tearDown(self):
+        SecurityTest.tearDown(self)
+        FSPSMaker.tearDown(self)
+
+
 def test_suite():
     return TestSuite((
         makeSuite(FSPythonScriptTests),
+        makeSuite(FSPythonScriptCustomizationTests),
         ))
 
 if __name__ == '__main__':