[CMF-checkins] SVN: CMF/trunk/ CMFCore.FSImage: Supply class-level
defaults for 'alt', 'height', and 'width'
Tres Seaver
tseaver at palladion.com
Mon Nov 5 12:35:41 EST 2007
Log message for revision 81545:
CMFCore.FSImage: Supply class-level defaults for 'alt', 'height', and 'width'
o Avoids acquiring objects with the same names
(http://www.zope.org/Collectors/CMF/507)
Create svn:external to GenericSetup in its new location.
Fix up version.txt to indicate that the trunk is *never* released.
Changed:
_U CMF/trunk/
U CMF/trunk/CHANGES.txt
U CMF/trunk/CMFActionIcons/version.txt
U CMF/trunk/CMFCalendar/version.txt
U CMF/trunk/CMFCore/FSImage.py
U CMF/trunk/CMFCore/tests/test_FSImage.py
U CMF/trunk/CMFCore/version.txt
U CMF/trunk/CMFDefault/version.txt
U CMF/trunk/CMFTopic/version.txt
U CMF/trunk/CMFUid/version.txt
U CMF/trunk/DCWorkflow/version.txt
U CMF/trunk/EXTERNALS.txt
-=-
Property changes on: CMF/trunk
___________________________________________________________________
Name: svn:externals
- #
# Used for maintenance of external resources in this svn bundle. Edit
# this file as appropriate and then run the following command from within
# the checkout directory where this file lives on your local machine:
#
# svn propset svn:externals -F ./EXTERNALS.TXT .
#
GenericSetup svn://svn.zope.org/repos/main/GenericSetup/trunk
+ #
# Used for maintenance of external resources in this svn bundle. Edit
# this file as appropriate and then run the following command from within
# the checkout directory where this file lives on your local machine:
#
# svn propset svn:externals -F ./EXTERNALS.TXT .
#
GenericSetup svn://svn.zope.org/repos/main/Products.GenericSetup/trunk/Products/GenericSetup
Modified: CMF/trunk/CHANGES.txt
===================================================================
--- CMF/trunk/CHANGES.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CHANGES.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -17,6 +17,10 @@
Bug Fixes
+ - CMFCore.FSImage: Supply class-level defaults for 'alt', 'height',
+ and 'width', to avoid acquiring objects with the same names
+ (http://www.zope.org/Collectors/CMF/507)
+
- DCWorkflow.exportimport: Scripts with invalid types imported
after scripts with valid types will no longer place the valid
script twice. Scripts can also now be specified with meta_types
Modified: CMF/trunk/CMFActionIcons/version.txt
===================================================================
--- CMF/trunk/CMFActionIcons/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFActionIcons/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/CMFCalendar/version.txt
===================================================================
--- CMF/trunk/CMFCalendar/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFCalendar/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/CMFCore/FSImage.py
===================================================================
--- CMF/trunk/CMFCore/FSImage.py 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFCore/FSImage.py 2007-11-05 17:35:40 UTC (rev 81545)
@@ -41,6 +41,9 @@
meta_type = 'Filesystem Image'
content_type = 'unknown/unknown'
+ alt = ''
+ height = ''
+ width = ''
_data = None
manage_options = ({'label':'Customize', 'action':'manage_main'},)
Modified: CMF/trunk/CMFCore/tests/test_FSImage.py
===================================================================
--- CMF/trunk/CMFCore/tests/test_FSImage.py 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFCore/tests/test_FSImage.py 2007-11-05 17:35:40 UTC (rev 81545)
@@ -218,6 +218,23 @@
self.failUnless('bar' in headers.keys())
self.assertEqual(headers['test_path'], '/test_image')
+ def test_tag_with_acquired_clashing_attrs(self):
+ # See http://www.zope.org/Collectors/CMF/507
+ class Clash:
+ def __str__(self):
+ raise NotImplementedError
+
+ self.root.alt = Clash()
+ self.root.height = Clash()
+ self.root.width = Clash()
+
+ image = self._makeOne( 'test_image', 'test_image.gif' )
+ image = image.__of__( self.root )
+
+ tag = image.tag()
+ self.failUnless('alt=""' in tag)
+
+
def test_suite():
return unittest.TestSuite((
unittest.makeSuite(FSImageTests),
Modified: CMF/trunk/CMFCore/version.txt
===================================================================
--- CMF/trunk/CMFCore/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFCore/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/CMFDefault/version.txt
===================================================================
--- CMF/trunk/CMFDefault/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFDefault/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/CMFTopic/version.txt
===================================================================
--- CMF/trunk/CMFTopic/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFTopic/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/CMFUid/version.txt
===================================================================
--- CMF/trunk/CMFUid/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/CMFUid/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/DCWorkflow/version.txt
===================================================================
--- CMF/trunk/DCWorkflow/version.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/DCWorkflow/version.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -1 +1 @@
-CMF-2.1.0-alpha2
+trunk (unreleased)
Modified: CMF/trunk/EXTERNALS.txt
===================================================================
--- CMF/trunk/EXTERNALS.txt 2007-11-05 17:33:40 UTC (rev 81544)
+++ CMF/trunk/EXTERNALS.txt 2007-11-05 17:35:40 UTC (rev 81545)
@@ -5,4 +5,4 @@
#
# svn propset svn:externals -F ./EXTERNALS.TXT .
#
-GenericSetup svn://svn.zope.org/repos/main/GenericSetup/trunk
+GenericSetup svn://svn.zope.org/repos/main/Products.GenericSetup/trunk/Products/GenericSetup
More information about the CMF-checkins
mailing list