[Grok-dev] Re: the JSON work

Martijn Faassen faassen at startifact.com
Fri Apr 13 18:35:29 EDT 2007


Tim wrote:
>> I saw Tim (already a while ago) checked in tests for the json support
>> branch. This is great! Tim, can you report on the status of the branch
>> now? I'd like to get it merged if possible.
> 
> It works and the tests pass. But the question is if you think there are enough 
> tests and the approach is a little better than awful  :)

I already took a peek at the approach before, but I will look again and 
actually try a few things. I also hope at least one other person else 
will do a review. (easy for beginning contributors! check out the branch 
and try to do get some JSON views going).

Next time you get code done and you want people to review it, please 
drop a note to the list to push us a little bit. :)

Thanks for the work!

Regards,

Martijn



More information about the Grok-dev mailing list