[Grok-dev] Re: SVN: grok/branches/neanderthal-startupspeed/ Killed the ZMI. (For grok).

[Philipp von Weitershausen]

Lennart Regebro wrote:
> Log message for revision 80440:
>   Killed the ZMI. (For grok).
>   
> 
> Changed:
>   U   grok/branches/neanderthal-startupspeed/buildout.cfg
>   U   grok/branches/neanderthal-startupspeed/src/grok/configure.zcml
> 
> -=-
> Modified: grok/branches/neanderthal-startupspeed/buildout.cfg
> ===================================================================
> --- grok/branches/neanderthal-startupspeed/buildout.cfg	2007-10-01 12:01:29 UTC (rev 80439)
> +++ grok/branches/neanderthal-startupspeed/buildout.cfg	2007-10-01 13:58:47 UTC (rev 80440)
> @@ -14,7 +14,8 @@
>  
>  [grokwiki]
>  recipe = zc.zope3recipes>=0.5.3:application
> -eggs = grokwiki
> +eggs = grokwiki 
> +       zc.configuration
>  site.zcml = <include package="grokwiki" />
>              <include package="zope.app.twisted" />
>  
> @@ -58,4 +59,5 @@
>  [test]
>  recipe = zc.recipe.testrunner
>  eggs = grok 
> +       zc.configuration
>  defaults = ['--tests-pattern', '^f?tests$', '-v']
> 
> Modified: grok/branches/neanderthal-startupspeed/src/grok/configure.zcml
> ===================================================================
> --- grok/branches/neanderthal-startupspeed/src/grok/configure.zcml	2007-10-01 12:01:29 UTC (rev 80439)
> +++ grok/branches/neanderthal-startupspeed/src/grok/configure.zcml	2007-10-01 13:58:47 UTC (rev 80440)
> @@ -6,23 +6,48 @@
>    <include package="zope.i18n" file="meta.zcml" />
>    <include package="zope.app.securitypolicy" file="meta.zcml" />
>    <include package="zope.app.zcmlfiles" file="meta.zcml" />
> +  <include package="zc.configuration" file="meta.zcml" />

With this line you've made 'zc.configuration' a hard dependency of grok. 
That means buildout.cfg is the wrong place to get the egg loaded. It 
*needs* be made a dependency in setup.py via install_requires.


Yay otherwise!!!

-- 
http://worldcookery.com -- Professional Zope documentation and training