[Grok-dev] Re: the fix for grok2html choking on Unicode

Philipp von Weitershausen philipp at weitershausen.de
Tue Sep 18 00:46:54 EDT 2007


Brandon Craig Rhodes wrote:
> The attached patch prevents grok2html from dying when presented with
> tutorials that include Unicode-encoded, non-ASCII characters.
> 
> The problem was that "docutils.core.publish_string()" returns a plain
> string, which needs to be decoded back into a Unicode object before
> being submitted to the Zope rendering logic.

Cool.

> I have not committed this myself because I'm not sure where to
> changelog it; the "CHANGES.txt" that I see in the Grok root directory
> seems to only describe changes to the application itself, whereas this
> is a change to a support tool that doesn't seem to get distributed
> when someone runs "grokproject"; at least, none of *my* Grok projects
> seem to have "grok2html" around, so I, as a user, would be confused to
> read about it in the CHANGES.txt that comes with Grok! :-)

Yeah. Don't worry about the changelog in this case. As you say yourself, 
it isn't an essential part of Grok and not in the Grok distribution.

Thanks for looking into this.

P.S.: Btw, isn't the codec called utf-8 (with a dash)? Hmm, I guess the 
underscore works too... You never stop learning :)


-- 
http://worldcookery.com -- Professional Zope documentation and training


More information about the Grok-dev mailing list