[Grok-dev] Re: Adding Valueindex

[Sebastian Ware]

19 maj 2008 kl. 14.43 skrev Martijn Faassen:

> Sebastian Ware wrote:
>> Could we consider adding ValueIndex to grok.Index?
>
> Sure, this is in zc.catalog, right? Could you describe a little bit  
> what you'd use it for? (as I'm pretty unfamiliar with it)
>
>> I don't know if you need tests for this (looks like the SetIndex  
>> lacks tests),
>
> It does have a test: grok/ftests/catalog/indexes_set.py
>
>> but the change is trivial:
>> grok/index.py:
>> from zc.catalog.catalogindex import ValueIndex
>> class Value(IndexDefinition):
>>   index_class = ValueIndex
>
> I think this is a good opportunity for you to produce a patch with  
> test. :)
>

I'll give it a shot. If the world ends in the next couple of days,  
you'll all know why... :)

Mvh Sebastian