[Grok-dev] five.grok - what changed to break this?

Martin Aspeli optilude at gmx.net
Sat Sep 27 07:00:15 EDT 2008


sylvain at infrae.com wrote:

>> That is, it was registering the 'static' resource directory adapter even
>> when there was no 'static/' directory to be found!
>>
> 
>   It's done the same in Grok. I think that's if the developer wants to add
> a directory afterwards, he don't have to restart his instance.

Really? That sounds dodgy if you ask me. Restarts are cheap. With this 
approach, we have one adapter for each and every package that gets 
grokked, even if only a small number are even used for templates and 
browser components.

>> I didn't break any tests with this change. I should've written a failing
>> test to prove it, but I don't have time for that right now and I need my
>> instance to start up. :)
>>
> 
>   Well, you didn't break any test, since tests are checking that there is
> an adapter for a static directory is registered, and it's the case, the
> Zope 3 one, which don't work in Zope 2.

Okay. Would you like me to revert?

Cheers,
Martin

-- 
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book



More information about the Grok-dev mailing list