[Grok-dev] Viewlets: Check for availability

Jan-Wijbrand Kolman janwijbrand at gmail.com
Tue Jun 28 03:08:38 EDT 2011


On 6/27/11 17:01 , Christian Klinger wrote:
> i am ok with the change. It's fine not to use the filter method of the
> BaseClass from ViewletManagerBase right? We lost then the filter for
> canAccess.

The ViewletManagerBase's update() does a lot of things, including
filtering (by default on canAccess indeed), sorting and calling the
viewlet update() methods. So I think it is the best place to check the
availability only after all of that has happened. Hence the override of
update() in grokcore.viewlet's ViewletManager component.

> So i am +1 for the change and releasing ;)

Cool. Will do asap.

regards, jw



More information about the Grok-dev mailing list