[Zodb-checkins] CVS: StandaloneZODB/ZEO - ClientStorage.py:1.26.4.34

[Jeremy Hylton]

Update of /cvs-repository/StandaloneZODB/ZEO
In directory cvs.zope.org:/tmp/cvs-serv5655

Modified Files:
      Tag: ZEO-ZRPC-Dev
	ClientStorage.py 
Log Message:
Add an XXX comment and delete some commented-out code.


=== StandaloneZODB/ZEO/ClientStorage.py 1.26.4.33 => 1.26.4.34 ===
                                                 tmin=min_disconnect_poll,
                                                 tmax=max_disconnect_poll)
+
+        # XXX What if we can only get a read-only connection and we
+        # want a read-write connection?  Looks like the current code
+        # will block forever.
+        
         if wait_for_server_on_startup:
             self._rpc_mgr.connect(sync=1)
         else:
@@ -332,12 +337,7 @@
         return oids
 
     def close(self):
-        # Close the manager first, so that it doesn't attempt to
-        # re-open the connection. 
         self._rpc_mgr.close()
-##        if self._server is not disconnected_stub:
-##            # XXX why doesn't the manager close this for us?
-##            self._server.rpc.close()
         if self._cache is not None:
             self._cache.close()