[Zodb-checkins] CVS: Zope/lib/python/ZODB - StorageTypes.py:1.1.2.2

Guido van Rossum guido@python.org
Mon, 25 Nov 2002 08:12:17 -0500


> Log Message:
> Make database sections work properly.
> 
> 
> === Zope/lib/python/ZODB/StorageTypes.py 1.1.2.1 => 1.1.2.2 ===
> --- Zope/lib/python/ZODB/StorageTypes.py:1.1.2.1	Sun Nov 24 19:10:13 2002
> +++ Zope/lib/python/ZODB/StorageTypes.py	Mon Nov 25 03:42:24 2002
> @@ -43,6 +43,9 @@
>          if kw.has_key(name):
>              kw[name] = asBoolean(kw[name])
>  
> +    if not kw.has_key('file_name'):
> +        raise RuntimeError, 'A file_name argument is required for FileStorage'
> +
>      return kw

Chris, can you explain the need for this?  In general, missing
arguments simply cause the constructor to fail.  Why isn't that enough
for FileStorage?  (IOW, what's your use case for this change?)

--Guido van Rossum (home page: http://www.python.org/~guido/)