[Zodb-checkins] CVS: ZODB3/ZEO - ClientStorage.py:1.72

[Guido van Rossum]

Update of /cvs-repository/ZODB3/ZEO
In directory cvs.zope.org:/tmp/cvs-serv29999

Modified Files:
	ClientStorage.py 
Log Message:
undoLog(): get rid of a mysterious "Eek!" comment.  Instead, clarify
in the docstring that filter should be None.  Also change the return
value if filter!=None from () to [], to match the type of what it
returns in other cases.


=== ZODB3/ZEO/ClientStorage.py 1.71 => 1.72 ===
--- ZODB3/ZEO/ClientStorage.py:1.71	Tue Oct  1 12:45:28 2002
+++ ZODB3/ZEO/ClientStorage.py	Tue Oct  1 14:45:56 2002
@@ -693,11 +693,16 @@
         return self._server.undoInfo(first, last, specification)
 
     def undoLog(self, first=0, last=-20, filter=None):
-        """Storage API: return a sequence of TransactionDescription objects."""
-        if filter is not None:
-            return () # can't pass a filter to server
+        """Storage API: return a sequence of TransactionDescription objects.
 
-        return self._server.undoLog(first, last) # Eek!
+        The filter argument should be None or left unspecified, since
+        it is impossible to pass the filter function to the server to
+        be executed there.  If filter is not None, an empty sequence
+        is returned.
+        """
+        if filter is not None:
+            return []
+        return self._server.undoLog(first, last)
 
     def versionEmpty(self, version):
         """Storage API: return whether the version has no transactions."""