[Zodb-checkins] CVS: Zope3/src/zodb - connection.py:1.22

[Jeremy Hylton]

Update of /cvs-repository/Zope3/src/zodb
In directory cvs.zope.org:/tmp/cvs-serv20302

Modified Files:
	connection.py 
Log Message:
Add XXX comment about overly complicated _handle_serial().


=== Zope3/src/zodb/connection.py 1.21 => 1.22 ===
--- Zope3/src/zodb/connection.py:1.21	Thu Mar 20 13:05:41 2003
+++ Zope3/src/zodb/connection.py	Thu Mar 20 13:08:27 2003
@@ -399,6 +399,10 @@
     def _handle_serial(self, store_return, oid=None, change=True):
         """Handle the returns from store() and tpc_vote() calls."""
 
+        # XXX We could simplify the storage interface if ZEO would
+        # raise the exception itself rather than passing it into the
+        # connection.
+
         # These calls can return different types depending on whether
         # ZEO is used.  ZEO uses asynchronous returns that may be
         # returned in batches by the ClientStorage.  ZEO1 can also
@@ -407,7 +411,7 @@
 
         # When _commit_sub() exceutes a store, there is no need to
         # update the _p_changed flag, because the subtransaction
-        # tpc_vote() calls already did this.  The change=1 argument
+        # tpcVote() calls already did this.  The change=1 argument
         # exists to allow _commit_sub() to avoid setting the flag
         # again.
         if not store_return: