[Zodb-checkins] CVS: ZODB3/ZODB - BaseStorage.py:1.36.2.3

[Jeremy Hylton]

Update of /cvs-repository/ZODB3/ZODB
In directory cvs.zope.org:/tmp/cvs-serv2851/ZODB

Modified Files:
      Tag: ZODB3-mvcc-2-branch
	BaseStorage.py 
Log Message:
Add XXX comment about the ambiguous state of history().


=== ZODB3/ZODB/BaseStorage.py 1.36.2.2 => 1.36.2.3 ===
--- ZODB3/ZODB/BaseStorage.py:1.36.2.2	Wed Nov 12 12:28:45 2003
+++ ZODB3/ZODB/BaseStorage.py	Wed Nov 12 17:20:15 2003
@@ -81,7 +81,7 @@
     def getSize(self):
         return len(self)*300 # WAG!
 
-    def history(self, oid, version, length=1):
+    def history(self, oid, version, length=1, filter=None):
         pass
 
     def modifiedInVersion(self, oid):
@@ -268,7 +268,12 @@
             # the pack time, we can't honor the MVCC request.
 
             # Note: history() returns the most recent record first.
+
+            # XXX The filter argument to history() only appears to be
+            # supported by FileStorage.  Perhaps it shouldn't be used.
             L = self.history(oid, "", n, lambda d: not d["version"])
+            if not L:
+                return
             for d in L:
                 if d["serial"] < tid:
                     start_time = d["serial"]